Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default settings not working with WP-CLI #219

Closed
gagan0123 opened this issue Mar 8, 2022 · 1 comment · Fixed by #222
Closed

Default settings not working with WP-CLI #219

gagan0123 opened this issue Mar 8, 2022 · 1 comment · Fixed by #222
Assignees
@felixarntz
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Bug An existing feature is broken
Milestone
1.0.0-beta.2

Comments

@gagan0123
Copy link

Bug Description

When the plugin is activated using wp-cli the default options are not saved.

Steps to reproduce

  1. Install the plugin either via GUI wp-admin/plugins.php or via CLI wp plugin install performance-lab
  2. Activate the plugin using wp plugin activate performance-lab
  3. Check Performance Lab plugin settings

Screenshots

image

Additional Context
@felixarntz felixarntz self-assigned this Mar 8, 2022
@felixarntz felixarntz added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure Needs Dev Anything that requires development (e.g. a pull request) labels Mar 8, 2022
@felixarntz felixarntz added this to the 1.0.0-beta.2 milestone Mar 8, 2022
@felixarntz
Copy link
Member

This can be fixed together with #218, as it's the same cause for both of these problems. I'll open a PR.

@felixarntz felixarntz mentioned this issue Mar 8, 2022
Merged
3 tasks
@felixarntz felixarntz added Needs Review and removed Needs Dev Anything that requires development (e.g. a pull request) labels Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixarntz felixarntz

Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Bug An existing feature is broken
Projects
None yet
Milestone
1.0.0-beta.2
Development

Successfully merging a pull request may close this issue.

Replace unreliable activation hook with default value for enabled modules WordPress/performance
2 participants
@gagan0123 @felixarntz