Min/max aspect ratios should be be rounded to a fixed nearest decimal

[westonruter]

Looking at a site in the wild I see the following in the page source:

"minViewportAspectRatio":0.40000000000000002220446049250313080847263336181640625,"maxViewportAspectRatio":2.5

This is a laughable minViewportAspectRatio. Nevertheless, the values 0.4 and 2.5 are what show up in the source:

performance/plugins/optimization-detective/storage/data.php

Line 313 in ebec285

return (float) apply_filters( 'od_minimum_viewport_aspect_ratio', 0.4 );

performance/plugins/optimization-detective/storage/data.php

Line 335 in ebec285

return (float) apply_filters( 'od_maximum_viewport_aspect_ratio', 2.5 );

Aren't floating point numbers fun.

I'm not sure how having such a long decimal would be prevented, as the return value of the functions there is sent straight to be exported as JSON here:

performance/plugins/optimization-detective/detection.php

Lines 91 to 93 in ebec285

	$detect_args = array(
	'minViewportAspectRatio' => od_get_minimum_viewport_aspect_ratio(),
	'maxViewportAspectRatio' => od_get_maximum_viewport_aspect_ratio(),

performance/plugins/optimization-detective/detection.php

Line 122 in ebec285

wp_json_encode( $detect_args )

Not a big issue.

[ShyamGadde]

Just thinking out loud here...

When exploring potential solutions, one idea that came to mind was to convert the float values to strings before JSON encoding. Then on the client side, we could convert them back to numbers when needed. This approach seems straightforward, though it introduces an extra step in handling these values.

I also came across another potential solution involving PHP's serialize_precision setting:

$original_precision = ini_get( 'serialize_precision' );
ini_set( 'serialize_precision', -1 );
// ... wp_json_encode( $detect_args ) ...
ini_set( 'serialize_precision', $original_precision );

This seems to address the issue as well, but I'm not entirely sure about the potential pitfalls of changing configuration values at runtime. It doesn’t feel like the cleanest approach.