Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a way to mark patterns as "Site building" #534

Closed
jameskoster opened this issue Oct 27, 2022 · 7 comments
Closed

Consider a way to mark patterns as "Site building" #534

jameskoster opened this issue Oct 27, 2022 · 7 comments

Comments

@jameskoster
Copy link

The pattern categories that appear in Gutenberg are being revised in WordPress/gutenberg#44501. As a part of that process a number of pattern types have been identified that users should find only when "site building", IE editing a template:

  • Headers
  • Footers
  • Post Content (for Query loops)
  • Comments (for Single templates)
  • Pagination / Comment pagination
  • Archive headings
  • 404 (when editing the 404 template)
  • Search (when editing the search template)

As we connect the Inserter with the Pattern Directory (WordPress/gutenberg#44611), a need arises to mark site building patterns appropriately so that they can be omitted when editing content.

I don't know if this distinction should be internal only, or whether we might want to include it in the Pattern Directory filtering options as well. That probably needs some design exploration and/or input from the community.

@ryelle
Copy link
Contributor

ryelle commented Oct 27, 2022

whether we might want to include it in the Pattern Directory filtering options as well

There was some exploration for front-end filtering here: #395.

I've marked this needs design for literally how to mark patterns as "site building", since it sounds like something that should be decided by the pattern author in the creation flow.

@jameskoster
Copy link
Author

Perhaps it's only the category that needs to be marked as "site building"? Then the block editor car surface those categories contextually (IE when editing templates).

There's certainly a design element, but I imagine there are many ways to approach the implementation on the engineering side too.

@ryelle
Copy link
Contributor

ryelle commented Oct 27, 2022

Does this already work some way in Gutenberg? I think the pattern directory would follow however it's implemented in Gutenberg.

@jameskoster
Copy link
Author

Not that I'm aware of.

@jasmussen
Copy link

Worth noting that I would think both regular and site building patterns could be available in the site editor, whereas the post editor would only contain the regular patterns.

@jameskoster
Copy link
Author

Agreed, with the nuance that the template editor (accessed through the post editor 🙈) should also surface site building patterns.

@ryelle
Copy link
Contributor

ryelle commented Nov 15, 2022

From WordPress/gutenberg#44501 it sounds like the categories will be the split point — so we don't need to add any extra meta to patterns.

@ryelle ryelle closed this as completed Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants