From 3335508df0c5a23d01ac5525dd499b530f18ae8a Mon Sep 17 00:00:00 2001 From: Zack Krida Date: Tue, 28 Feb 2023 09:00:07 -0500 Subject: [PATCH 1/2] Update home link screen reader text --- frontend/src/components/VHeader/VHomeLink.vue | 5 ++++- frontend/src/locales/scripts/en.json5 | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/frontend/src/components/VHeader/VHomeLink.vue b/frontend/src/components/VHeader/VHomeLink.vue index d15c39cf89b..bd20d4dce09 100644 --- a/frontend/src/components/VHeader/VHomeLink.vue +++ b/frontend/src/components/VHeader/VHomeLink.vue @@ -4,7 +4,10 @@ class="flex items-stretch rounded-sm focus-visible:outline-none focus-visible:ring focus-visible:ring-pink focus-visible:ring-offset-1 focus-visible:ring-offset-tx" :class="variant === 'dark' ? 'text-dark-charcoal' : 'text-white'" > - + diff --git a/frontend/src/locales/scripts/en.json5 b/frontend/src/locales/scripts/en.json5 index ab88c414abc..b258d27823a 100644 --- a/frontend/src/locales/scripts/en.json5 +++ b/frontend/src/locales/scripts/en.json5 @@ -28,7 +28,7 @@ }, }, header: { - "home-link": "Home", + "home-link": "{openverse} Home", "about-nav-item": "Our Story", "source-nav-item": "Sources", "search-guide-nav-item": "Search Guide", From 3a2645adb3dc64934b6103caaf621acca3c86798 Mon Sep 17 00:00:00 2001 From: Zack Krida Date: Tue, 28 Feb 2023 09:36:28 -0500 Subject: [PATCH 2/2] Hardcode openverse link text in tests --- frontend/test/playwright/e2e/header-internal.spec.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frontend/test/playwright/e2e/header-internal.spec.ts b/frontend/test/playwright/e2e/header-internal.spec.ts index 50e2ac45d18..e24893c2dd9 100644 --- a/frontend/test/playwright/e2e/header-internal.spec.ts +++ b/frontend/test/playwright/e2e/header-internal.spec.ts @@ -84,7 +84,9 @@ test.describe("Header internal", () => { const homeUrl = page.url() await clickMenuButton(page) await page.getByRole("link", { name: t("navigation.about") }).click() - await page.getByRole("link", { name: t("header.home-link") }).click() + // "Openverse Home" is hardcoded because our translation helper + // doesn't support named interpolation. + await page.getByRole("link", { name: "Openverse Home" }).click() expect(page.url()).toBe(homeUrl) }) })