Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new VNavLink component #486

Closed
1 task
obulat opened this issue Nov 28, 2022 · 0 comments
Closed
1 task

Add a new VNavLink component #486

obulat opened this issue Nov 28, 2022 · 0 comments
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Nov 28, 2022

From WordPress/openverse-frontend#2009

For the active state needed, I created a new "Link" component with resting, hover, and disabled states for its active and inactive versions. The component can be reused in other areas as is consistent with other actions across the site.

Description

The VNavLink component is used in the VPageLinks component in the new header (VHeaderInternal) and the footer (VFooter) . It should be a wrapper over the VLink component that provides interaction styles.

API

Props

Name Type Description
href string The URL for the linked page. Can be relative (for internal links) or absolute (for external links).
mode 'light', 'dark' The VNavLink should have a dark mode for the VHeaderInternal's modal.

Slots

Name Slot props Description
default - The text of the link

State

Name Type Description

Events

Name Associated data Description
click - -

Code samples

Dependencies

References

Implementation

  • 🙋 I would be interested in implementing this component.
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🕹 aspect: interface Concerns end-users' experience with the software ⛔ status: blocked Blocked & therefore, not ready for work 🌟 goal: addition Addition of new feature labels Nov 28, 2022
@obulat obulat changed the title Add a new Link component Add a new VNavLink component Dec 1, 2022
@obulat obulat removed the ⛔ status: blocked Blocked & therefore, not ready for work label Dec 1, 2022
@obulat obulat self-assigned this Dec 1, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
@obulat obulat removed their assignment Mar 16, 2023
@obulat obulat closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

No branches or pull requests

1 participant