Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus outline in media type selection dropdown is cropped on the right #464

Closed
dhruvkb opened this issue Feb 2, 2023 · 4 comments
Closed
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Feb 2, 2023

Description

The focus outline in the media type selection dropdown is cropped from the right side.

Reproduction

  1. Search for something.
  2. Using the keyboard navigate to the media type selection dropdown.
  3. Move the selection up and down.
  4. See incorrect focus outline.

Screenshots

Screenshot 2023-02-02 at 1 31 37 PM

Environment

  • Device: MacBook Pro M1
  • OS: macOS Ventura 13.1
  • Browser: Firefox
  • Version: 109.01

Additional context

This seems to be browser-specific because it cannot be reproduced in Safari.

@dhruvkb dhruvkb added good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Feb 2, 2023
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
@obulat
Copy link
Contributor

obulat commented Mar 15, 2023

I'm on Firefox 110.0.1 (64-bit) 111.0 (64-bit) (all other environment properties are the same), and I can't reproduce this. Can you still see it, @dhruvkb ?

@sarayourfriend
Copy link
Collaborator

sarayourfriend commented Mar 20, 2023

I also cannot reproduce it on Firefox nightly on Linux.

@dhruvkb
Copy link
Member Author

dhruvkb commented Mar 20, 2023

I can still see it, even with Firefox 111.0 64-bit (same as @obulat), but since most of you don't, I am starting to suspect it might be an issue with my setup. Let's drop this to low priority.

Screenshot 2023-03-20 at 1 13 44 PM

@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed and removed 🟧 priority: high Stalls work on the project or its dependents labels Mar 28, 2023
@dhruvkb
Copy link
Member Author

dhruvkb commented Nov 24, 2023

Did a little investigation into why this is specific to me and I think this might be it. This behaviour only occurs when the following macOS setting is enabled.

Screenshot 2023-11-24 at 10 28 51 AM

Setting the scrollbar visibility to "Always" leads to the scrollbar-gutter CSS property in Firefox reserving a little space for the scrollbar on the edge, which then cuts off the right edge of the content. Chrome is able to handle this quite well so we can close this as a shortcoming of Firefox requiring no work from our end.

@dhruvkb dhruvkb closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2023
@dhruvkb dhruvkb moved this from 📋 Backlog to 🗑 Discarded in Openverse Backlog Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

No branches or pull requests

3 participants