Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related endpoint does not return all of the necessary propertes #3403

Closed
obulat opened this issue Nov 27, 2023 · 0 comments · Fixed by #3408
Closed

Related endpoint does not return all of the necessary propertes #3403

obulat opened this issue Nov 27, 2023 · 0 comments · Fixed by #3408
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API

Comments

@obulat
Copy link
Contributor

obulat commented Nov 27, 2023

Description

The related results are missing required properties such as license_version.

Reproduction

  1. Check that the image single result and search result have the necessary properties including the license_version: (https://api.openverse.engineering/v1/images/cf016656-2584-4f6e-827e-386d124a2d0a/ and https://api.openverse.engineering/v1/images/?q=Eastern%20Phoebe%20(Sayornis%20phoebe)%202022-04-28%20(2))
  2. See that the same image has null for license_version, height, width, attribution, creator_url when it's returned as a related result.

Additional context

I guess the related endpoint does not get the search context.

@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API labels Nov 27, 2023
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Nov 27, 2023
@dhruvkb dhruvkb self-assigned this Nov 28, 2023
@dhruvkb dhruvkb moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Nov 28, 2023
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Nov 28, 2023
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Dec 1, 2023
@openverse-bot openverse-bot moved this from ✅ Done to 📋 Backlog in Openverse Backlog Dec 1, 2023
@dhruvkb dhruvkb moved this from 📋 Backlog to ✅ Done in Openverse Backlog Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants