Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SychronousOnlyOperation exceptions #2861

Closed
dhruvkb opened this issue Aug 23, 2023 · 2 comments
Closed

Handle SychronousOnlyOperation exceptions #2861

dhruvkb opened this issue Aug 23, 2023 · 2 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Aug 23, 2023

Description

The conversion of the API to ASGI raises SychronousOnlyOperation exceptions in Sentry. This should be resolved or appropriately handled.
@dhruvkb dhruvkb added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix labels Aug 23, 2023
@dhruvkb dhruvkb added this to the Django ASGI milestone Aug 23, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Aug 23, 2023
@dhruvkb dhruvkb added 💻 aspect: code Concerns the software code in the repository 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 23, 2023
@sentry-io
Copy link

sentry-io bot commented Aug 23, 2023

Sentry issue: OPENVERSE-API-A9

@sarayourfriend
Copy link
Collaborator

This was due to a bad deployment of a production image that did not include the underlying changes required to use gunicorn from the baked-in run command. It actually doesn't have anything to do with the ASGI conversion generally, fortunately. Only be consequence of my error in deploying it. The Sentry issue was resolved once the deployment was reversed.

Related to #2785

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Aug 24, 2023
@sarayourfriend sarayourfriend removed this from the Django ASGI milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhruvkb @sarayourfriend