Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"header-ltr › searchbar active" visual regression test is broken #2357

Closed
zackkrida opened this issue Jun 8, 2023 · 1 comment
Closed

"header-ltr › searchbar active" visual regression test is broken #2357

zackkrida opened this issue Jun 8, 2023 · 1 comment
Assignees
@zackkrida
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: frontend Related to the Nuxt frontend

Comments

@zackkrida
Copy link
Member

zackkrida commented Jun 8, 2023 •
edited
Loading

Description

Failed run: https://github.com/WordPress/openverse/actions/runs/5214000036/jobs/9409755595

The test visual-regression/components/header.spec.ts:69:11 › header-ltr › screen at breakpoint xs with width 340 › searchbar active is flaky. Noticed after merging #2196.

It appears that the test occasionally doesn't render the icons which causes the failure.
@zackkrida zackkrida added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Jun 8, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Jun 8, 2023
@sarayourfriend sarayourfriend mentioned this issue Jun 9, 2023
Closed
@zackkrida zackkrida self-assigned this Jun 9, 2023
This was referenced Jun 9, 2023
Closed
Merged
Closed
@sarayourfriend sarayourfriend mentioned this issue Jun 13, 2023
Merged
8 tasks
@zackkrida
Copy link
Member Author

Fixed via #2378. For context this test itself was fine, but some latency in SVG rendering was introduced (we're uncertain how) by adding a playwright test fixture which made network requests.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zackkrida zackkrida

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try waiting for load of SVGs WordPress/openverse
1 participant
@zackkrida