From 2a632ea2abe525e48bd5df0bfb9c86fb0944bb76 Mon Sep 17 00:00:00 2001 From: Olga Bulat Date: Mon, 3 Oct 2022 13:13:36 +0300 Subject: [PATCH 1/8] Implement the composite search bar in the mobile search header --- src/components/VHeader/VHeaderDesktop.vue | 2 +- .../VHeader/VHeaderMobile/VBackButton.vue | 40 ++++ .../VHeader/VHeaderMobile/VHeaderMobile.vue | 208 ------------------ src/components/VHeader/VLogoButton.vue | 9 +- .../VHeader/VSearchBar/VClearButton.vue | 25 +++ .../VHeader/meta/VHeaderMobile.stories.mdx | 8 - src/components/VIconButton/VIconButton.vue | 1 + src/locales/en.json | 6 +- 8 files changed, 76 insertions(+), 223 deletions(-) create mode 100644 src/components/VHeader/VHeaderMobile/VBackButton.vue delete mode 100644 src/components/VHeader/VHeaderMobile/VHeaderMobile.vue create mode 100644 src/components/VHeader/VSearchBar/VClearButton.vue diff --git a/src/components/VHeader/VHeaderDesktop.vue b/src/components/VHeader/VHeaderDesktop.vue index 5dc3b1232b..659f79b8aa 100644 --- a/src/components/VHeader/VHeaderDesktop.vue +++ b/src/components/VHeader/VHeaderDesktop.vue @@ -7,7 +7,7 @@ : 'border-white' " > - + + + + + + + + + diff --git a/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue b/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue deleted file mode 100644 index b2af3f04ef..0000000000 --- a/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue +++ /dev/null @@ -1,208 +0,0 @@ - - - diff --git a/src/components/VHeader/VLogoButton.vue b/src/components/VHeader/VLogoButton.vue index b413b9ef65..c4cc8c632a 100644 --- a/src/components/VHeader/VLogoButton.vue +++ b/src/components/VHeader/VLogoButton.vue @@ -5,7 +5,8 @@ :aria-label="$t('header.home-link')" variant="plain" size="disabled" - class="max-w-min text-dark-charcoal hover:bg-yellow" + class="text-dark-charcoal hover:bg-yellow" + :class="fixedSize ? 'h-12 w-12 flex-shrink-0' : 'max-w-min'" > + + + + diff --git a/src/components/VHeader/meta/VHeaderMobile.stories.mdx b/src/components/VHeader/meta/VHeaderMobile.stories.mdx index 2e50ee52d4..3c64bc62ab 100644 --- a/src/components/VHeader/meta/VHeaderMobile.stories.mdx +++ b/src/components/VHeader/meta/VHeaderMobile.stories.mdx @@ -10,14 +10,6 @@ import VHeaderMobile from '~/components/VHeader/VHeaderMobile/VHeaderMobile.vue' export const Template = (args) => ({ diff --git a/src/components/VIconButton/VIconButton.vue b/src/components/VIconButton/VIconButton.vue index 291eca97e6..2feb4de23d 100644 --- a/src/components/VIconButton/VIconButton.vue +++ b/src/components/VIconButton/VIconButton.vue @@ -28,6 +28,7 @@ import VButton, { type ButtonProps } from '~/components/VButton.vue' const SIZE_MAP = Object.freeze({ tiny: { icon: 'w-6 h-6', button: 'w-6 h-6' }, small: { icon: 'w-6 h-6', button: 'w-10 h-10' }, + smaller: { icon: 'w-6 h-6', button: 'w-8 h-8' }, // TODO: audit the sizes after new header is done. 'new-small': { icon: 'w-4 h-4', button: 'w-8 h-8' }, 'search-small': { diff --git a/src/locales/en.json b/src/locales/en.json index 5bb0682c15..2711eb4bf4 100644 --- a/src/locales/en.json +++ b/src/locales/en.json @@ -59,7 +59,8 @@ "simple": "Filters", "with-count": "{count} Filter|{count} Filters" }, - "see-results": "See results" + "see-results": "See results", + "back-button": "Go back" }, "navigation": { "about": "About", @@ -374,7 +375,8 @@ "model-3d": "3D Models", "all": "content", "collection-placeholder": "Search this collection", - "button": "Search" + "button": "Search", + "clear": "Clear" }, "license-description": { "title": "License CC", From 154868c83dc6a5b22f51627d471f1f51f59854f1 Mon Sep 17 00:00:00 2001 From: Olga Bulat Date: Thu, 6 Oct 2022 16:58:33 +0300 Subject: [PATCH 2/8] Add VHeaderMobile and VInputModal --- .../VHeader/VHeaderMobile/VHeaderMobile.vue | 348 ++++++++++++++++++ src/components/VModal/VInputModal.vue | 141 +++++++ .../VRecentSearches/VRecentSearches.vue | 20 +- src/layouts/default.vue | 6 +- 4 files changed, 507 insertions(+), 8 deletions(-) create mode 100644 src/components/VHeader/VHeaderMobile/VHeaderMobile.vue create mode 100644 src/components/VModal/VInputModal.vue diff --git a/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue b/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue new file mode 100644 index 0000000000..1d90abacd9 --- /dev/null +++ b/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue @@ -0,0 +1,348 @@ + + + + + diff --git a/src/components/VModal/VInputModal.vue b/src/components/VModal/VInputModal.vue new file mode 100644 index 0000000000..2cf0d05828 --- /dev/null +++ b/src/components/VModal/VInputModal.vue @@ -0,0 +1,141 @@ + + diff --git a/src/components/VRecentSearches/VRecentSearches.vue b/src/components/VRecentSearches/VRecentSearches.vue index ee9ad928ac..061e0e89d1 100644 --- a/src/components/VRecentSearches/VRecentSearches.vue +++ b/src/components/VRecentSearches/VRecentSearches.vue @@ -1,18 +1,21 @@ - diff --git a/src/components/VHeader/VHeaderMobile/VContentSettingsButton.vue b/src/components/VHeader/VHeaderMobile/VContentSettingsButton.vue index 501453c422..c086bd4e03 100644 --- a/src/components/VHeader/VHeaderMobile/VContentSettingsButton.vue +++ b/src/components/VHeader/VHeaderMobile/VContentSettingsButton.vue @@ -1,36 +1,32 @@ - - - diff --git a/src/components/VHeader/VHeaderMobile/VSearchBarButton.vue b/src/components/VHeader/VHeaderMobile/VSearchBarButton.vue new file mode 100644 index 0000000000..2c87cb16e8 --- /dev/null +++ b/src/components/VHeader/VHeaderMobile/VSearchBarButton.vue @@ -0,0 +1,52 @@ + + diff --git a/src/components/VHeader/VSearchBar/VClearButton.vue b/src/components/VHeader/VSearchBar/VClearButton.vue deleted file mode 100644 index 6ddfa75ff1..0000000000 --- a/src/components/VHeader/VSearchBar/VClearButton.vue +++ /dev/null @@ -1,25 +0,0 @@ - - - From dfe09068d2dd2f0887310088b3a2267f1871ab15 Mon Sep 17 00:00:00 2001 From: Olga Bulat Date: Sun, 9 Oct 2022 07:19:49 +0300 Subject: [PATCH 6/8] Add hover styles to the buttons --- src/components/VHeader/VHeaderMobile/VHeaderMobile.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue b/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue index 831638ead1..0226befbe1 100644 --- a/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue +++ b/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue @@ -32,6 +32,7 @@ :inner-size="8" :aria-label="$t('header.back-button')" :rtl-flip="true" + inner-area-classes="hover:bg-dark-charcoal hover:text-white" @click="handleBack" /> @@ -66,7 +67,7 @@ v-show="searchBarIsActive && searchTerm" :icon-path="closeIcon" :aria-label="$t('browse-page.search-form.clear')" - inner-area-classes="bg-white" + inner-area-classes="bg-white hover:bg-dark-charcoal-10" @click="clearSearchText" /> Date: Sun, 9 Oct 2022 08:40:58 +0300 Subject: [PATCH 7/8] Remove defaults for inner-area-classes --- src/components/VHeader/VHeaderMobile/VHeaderMobile.vue | 2 +- src/components/VHeader/VHeaderMobile/VSearchBarButton.vue | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue b/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue index 0226befbe1..0a42c79f1f 100644 --- a/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue +++ b/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue @@ -32,7 +32,7 @@ :inner-size="8" :aria-label="$t('header.back-button')" :rtl-flip="true" - inner-area-classes="hover:bg-dark-charcoal hover:text-white" + inner-area-classes="bg-dark-charcoal-10 hover:bg-dark-charcoal hover:text-white" @click="handleBack" /> diff --git a/src/components/VHeader/VHeaderMobile/VSearchBarButton.vue b/src/components/VHeader/VHeaderMobile/VSearchBarButton.vue index 2c87cb16e8..ab52170ae8 100644 --- a/src/components/VHeader/VHeaderMobile/VSearchBarButton.vue +++ b/src/components/VHeader/VHeaderMobile/VSearchBarButton.vue @@ -41,7 +41,7 @@ export default defineComponent({ }, innerAreaClasses: { type: String, - default: 'bg-dark-charcoal-10', + default: '', }, rtlFlip: { type: Boolean, From 5f431abd15fdeea6f738a3110b9d37fd8273f8a0 Mon Sep 17 00:00:00 2001 From: Olga Bulat Date: Sun, 9 Oct 2022 08:50:22 +0300 Subject: [PATCH 8/8] Add the `isFetching` prop to VContentSettingsModal --- src/components/VHeader/VHeaderMobile/VHeaderMobile.vue | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue b/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue index 0a42c79f1f..f70b569e15 100644 --- a/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue +++ b/src/components/VHeader/VHeaderMobile/VHeaderMobile.vue @@ -76,7 +76,10 @@ > {{ searchStatus }} - +