From 24266b6a6fb14e2d1b467826de431f40f4899b75 Mon Sep 17 00:00:00 2001 From: Zack Krida Date: Mon, 28 Mar 2022 17:04:20 -0400 Subject: [PATCH 1/8] Remove scss lang directives from Vue SFC style tags; add eslint rule to enforce --- .eslintrc.js | 6 + src/components/CopyButton.vue | 6 +- src/components/ExtensionBrowsers.vue | 11 +- src/components/LoadingIcon.vue | 3 +- src/components/LocaleSelector.vue | 150 ------------------ src/components/SketchFabViewer.vue | 2 +- .../VAudioDetails/VAudioDetails.vue | 8 +- src/components/VErrorSection/VErrorImage.vue | 9 +- src/components/VImageGrid/VImageGrid.vue | 2 +- src/components/VNotificationBanner.vue | 4 +- src/components/VSkeleton/VGridSkeleton.vue | 2 +- src/layouts/default.vue | 11 +- src/pages/extension.vue | 100 +++++------- src/pages/sources.vue | 3 +- 14 files changed, 76 insertions(+), 241 deletions(-) delete mode 100644 src/components/LocaleSelector.vue diff --git a/.eslintrc.js b/.eslintrc.js index 53ae8e253d..a5407c73c9 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -44,6 +44,12 @@ module.exports = { 'vue/html-closing-bracket-newline': 'off', 'vue/html-indent': 'off', 'vue/singleline-html-element-content-newline': 'off', + 'vue/block-lang': [ + 'error', + { + style: { allowNoLang: true }, + }, + ], 'vue/component-name-in-template-casing': [ 'error', 'PascalCase', diff --git a/src/components/CopyButton.vue b/src/components/CopyButton.vue index a245eb66d9..040482b426 100644 --- a/src/components/CopyButton.vue +++ b/src/components/CopyButton.vue @@ -61,7 +61,11 @@ export default { } - diff --git a/src/components/LoadingIcon.vue b/src/components/LoadingIcon.vue index 11aba5b9fe..0abf4a8240 100644 --- a/src/components/LoadingIcon.vue +++ b/src/components/LoadingIcon.vue @@ -13,7 +13,7 @@ export default { } - diff --git a/src/components/SketchFabViewer.vue b/src/components/SketchFabViewer.vue index 6871442a55..a3e1f16a9c 100644 --- a/src/components/SketchFabViewer.vue +++ b/src/components/SketchFabViewer.vue @@ -69,7 +69,7 @@ export default { }, } - diff --git a/src/components/VImageGrid/VImageGrid.vue b/src/components/VImageGrid/VImageGrid.vue index 02c8265817..fe9643ca84 100644 --- a/src/components/VImageGrid/VImageGrid.vue +++ b/src/components/VImageGrid/VImageGrid.vue @@ -65,7 +65,7 @@ export default { } - diff --git a/src/pages/sources.vue b/src/pages/sources.vue index 2900046bbf..3f18c55cf7 100644 --- a/src/pages/sources.vue +++ b/src/pages/sources.vue @@ -194,8 +194,7 @@ const SourcePage = { export default SourcePage - - diff --git a/src/components/VMediaInfo/VCopyLicense.vue b/src/components/VMediaInfo/VCopyLicense.vue index 796891d719..50eaa610eb 100644 --- a/src/components/VMediaInfo/VCopyLicense.vue +++ b/src/components/VMediaInfo/VCopyLicense.vue @@ -121,7 +121,7 @@ - { +describe('VCopyButton', () => { let options = null let props = null @@ -20,28 +20,28 @@ describe('CopyButton', () => { }) it('should render correct contents', () => { - const wrapper = render(CopyButton, options) + const wrapper = render(VCopyButton, options) expect(wrapper.find('button')).toBeDefined() }) it('data.success should be false by default', () => { - const wrapper = render(CopyButton, options) + const wrapper = render(VCopyButton, options) expect(wrapper.vm.$data.success).toBe(false) }) it('data.success should be false by default', () => { - const wrapper = render(CopyButton, options) + const wrapper = render(VCopyButton, options) expect(wrapper.vm.$data.success).toBe(false) }) it('should set data.success to true', () => { - const wrapper = render(CopyButton, options) + const wrapper = render(VCopyButton, options) wrapper.vm.onCopySuccess(eventData) expect(wrapper.vm.$data.success).toBe(true) }) it('should set data.success to back to false after 2s', (done) => { - const wrapper = render(CopyButton, options) + const wrapper = render(VCopyButton, options) wrapper.vm.onCopySuccess(eventData) setTimeout(() => { expect(wrapper.vm.$data.success).toBe(false) @@ -50,19 +50,19 @@ describe('CopyButton', () => { }) it('should call clearSelection', () => { - const wrapper = render(CopyButton, options) + const wrapper = render(VCopyButton, options) wrapper.vm.onCopySuccess(eventData) expect(eventData.clearSelection).toHaveBeenCalled() }) it('should emit copied event', () => { - const wrapper = render(CopyButton, options) + const wrapper = render(VCopyButton, options) wrapper.vm.onCopySuccess(eventData) expect(wrapper.emitted().copied).toBeTruthy() }) it('should emit copyFailed event', () => { - const wrapper = render(CopyButton, options) + const wrapper = render(VCopyButton, options) wrapper.vm.onCopyError(eventData) expect(wrapper.emitted().copyFailed).toBeTruthy() })