Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add types to utils/string-to-boolean.js #925

Closed
1 task
sarayourfriend opened this issue Feb 21, 2022 · 0 comments · Fixed by #1023
Closed
1 task

Add types to utils/string-to-boolean.js #925

sarayourfriend opened this issue Feb 21, 2022 · 0 comments · Fixed by #1023
Assignees
@dhruvkb
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Milestone
TypeScriptification

Comments

@sarayourfriend
Copy link
Contributor

Description

Add type checking to string-to-boolean.js. This module has zero dependencies. Make sure to add it to tsconfig.json's include list.

Additional context

Part of an ongoing effort to add type checking to parts of the project that can be type checked.

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Feb 21, 2022
@sarayourfriend sarayourfriend added this to the TypeScriptification milestone Feb 21, 2022
@sarayourfriend sarayourfriend mentioned this issue Feb 21, 2022
Closed
1 task
@sarayourfriend sarayourfriend removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Feb 21, 2022
@dhruvkb dhruvkb self-assigned this Feb 28, 2022
@dhruvkb dhruvkb mentioned this issue Feb 28, 2022
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dhruvkb dhruvkb

Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Milestone
TypeScriptification
Development

Successfully merging a pull request may close this issue.

Convert 6 utils to TypeScript WordPress/openverse-frontend
2 participants
@dhruvkb @sarayourfriend