Add eslint-plugin-eslint-comments to prevent accidentally leaving disabled rules for entire files

[krysal]

Problem

Some ESlint rules can be disabled in block comments for specific parts of a file, we use this for disabled some texts that should not be translated for example. The problem is that this approach is prone to forgetting to close the exception as happened in the VImageDetails component.

openverse-frontend/src/components/VImageDetails/VImageDetails.vue

Lines 41 to 50 in 8e50891

	<!-- eslint-disable @intlify/vue-i18n/no-raw-text -->
	{{ imageWidth }} &times; {{ imageHeight }}
	{{ $t('image-details.information.pixels') }}
	</dd>
	</div>
	</dl>
	</section>
	</template>
	<script>

Description

Adding eslint-plugin-eslint-comments can help offload this burden from the developer who writes the exception comment as well as those who review the changes.

Alternatives

Be aware in code reviews that ESlint comments are not applied without their corresponding closure.

Additional context

Recommended in #898 by @sarayourfriend.

Implementation

• 🙋 I would be interested in implementing this feature.