Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Switching search type from an SSR'd audio results page to all content does not fetch all results #860

Closed
1 task
sarayourfriend opened this issue Feb 14, 2022 · 1 comment · Fixed by #880
Closed
1 task

Switching search type from an SSR'd audio results page to all content does not fetch all results #860

sarayourfriend opened this issue Feb 14, 2022 · 1 comment · Fixed by #880
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@sarayourfriend
Copy link
Contributor

Description

Going from https://search-staging.openverse.engineering/search/audio?q=galah to https://search-staging.openverse.engineering/search?q=galah via the UI using the search type switcher does not fetch image results

Reproduction

  1. Go to https://search-staging.openverse.engineering/search/audio?q=galah
  2. Open the search type switcher in the header and select "all content"
  3. Note that only the single audio result is shown, no image results are fetched

Expectation

Switching the search type should re-fetch the results.

Resolution

  • 🙋 I would be interested in resolving this bug.
@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Feb 14, 2022
@zackkrida zackkrida removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Feb 15, 2022
@sarayourfriend
Copy link
Contributor Author

Probably best to wait to work on this until #851 and #867 are merged considering the fix for this is likely going to involve some state management changes.

@sarayourfriend sarayourfriend added the 🚧 status: blocked Blocked & therefore, not ready for work label Feb 15, 2022
@sarayourfriend sarayourfriend linked a pull request Feb 15, 2022 that will close this issue
Refactor media services #867
Merged
7 tasks
@sarayourfriend sarayourfriend removed a link to a pull request Feb 15, 2022
Refactor media services #867
Merged
7 tasks
@sarayourfriend sarayourfriend mentioned this issue Feb 18, 2022
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚧 status: blocked Blocked & therefore, not ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix browser back button handling in search pages WordPress/openverse-frontend
2 participants
@zackkrida @sarayourfriend