Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add eslint-plugin-import to enforce import order and extension consistency #855

Closed
1 task
sarayourfriend opened this issue Feb 11, 2022 · 0 comments · Fixed by #999
Closed
1 task

Add eslint-plugin-import to enforce import order and extension consistency #855

sarayourfriend opened this issue Feb 11, 2022 · 0 comments · Fixed by #999
Assignees
@sarayourfriend
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@sarayourfriend
Copy link
Contributor

Problem

There is no enforced consistency in how we import modules in JavaScript. Sometimes we use extensions for .js files and other times not.

In https://github.com/WordPress/openverse-frontend/discussions/465 we decided that it'd be good to enforce consistency here using eslint.

eslint-plugin-import has tons of helpful rules for this.

Description

Add esling-plugin-import to the eslint configuration.

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Feb 11, 2022
@sarayourfriend sarayourfriend mentioned this issue Feb 23, 2022
Merged
6 tasks
@sarayourfriend sarayourfriend self-assigned this Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarayourfriend sarayourfriend

Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add eslint rules for imports and eslint comments WordPress/openverse-frontend
1 participant
@sarayourfriend