Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Disable homepage search submission without a query #769

Closed
1 task
zackkrida opened this issue Feb 1, 2022 · 0 comments · Fixed by #829
Closed
1 task

Disable homepage search submission without a query #769

zackkrida opened this issue Feb 1, 2022 · 0 comments · Fixed by #829
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon

Comments

@zackkrida
Copy link
Member

Description

Currently, the homepage allows users to submit a search with no search query. We should block that, as it's one of the only explicit user-facing paths to the raw, query-less /search/ endpoint which has been identified as a problem in #596

Resolution

  • 🙋 I would be interested in resolving this bug.
@zackkrida zackkrida added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Feb 1, 2022
@zackkrida zackkrida modified the milestones: Postlaunch bug fixes and SEO improvements, Design cleanup Feb 1, 2022
@zackkrida zackkrida added the bug Something isn't working label Feb 4, 2022
@obulat obulat mentioned this issue Feb 8, 2022
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a check for blank search term before searching WordPress/openverse-frontend
1 participant
@zackkrida