Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Make Search results page ready for RTL #428

Closed
4 tasks done
Tracked by #421
obulat opened this issue Nov 18, 2021 · 3 comments
Closed
4 tasks done
Tracked by #421

Make Search results page ready for RTL #428

obulat opened this issue Nov 18, 2021 · 3 comments
Assignees

Comments

@obulat
Copy link
Contributor

obulat commented Nov 18, 2021

  • The search bar needs to have its button and input corners correctly rounded as well as its padding adjusted for RTL
  • The "safer browsing" flag icon needs to have its padding adjusted to match the LTR language padding: the flag icon is removed in the 'transitional styles' mockups.
  • The scroll to top button should be moved to the opposite corner
  • License icons and their corresponding text need to have their separation padding adjusted for RTL: this is done in Add Checkbox component #406 and Give licenses the full name and retire LicenseIcons #422
@obulat obulat mentioned this issue Nov 18, 2021
8 tasks
@obulat obulat self-assigned this Nov 18, 2021
@obulat
Copy link
Contributor Author

obulat commented Nov 19, 2021

@sarayourfriend , I don't quite understand what the last point means. This is what I can currently see in the audio results:
Screen Shot 2021-11-19 at 2 27 21 PM

@zackkrida
Copy link
Member

@obulat There's insufficient spacing between the license icons, the dot and the --:--, I believe.

@obulat obulat changed the title Search results page Make Search results page ready for RTL Dec 2, 2021
@obulat
Copy link
Contributor Author

obulat commented Dec 2, 2021

Closing this issue because all items are done.

@obulat obulat closed this as completed Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants