Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Move setting search media type from sub pages to the search page #361

Closed
1 task done
obulat opened this issue Oct 26, 2021 · 0 comments · Fixed by #362
Closed
1 task done

Move setting search media type from sub pages to the search page #361

obulat opened this issue Oct 26, 2021 · 0 comments · Fixed by #362
Assignees
@obulat
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@obulat
Copy link
Contributor

obulat commented Oct 26, 2021

Problem

Currently, the search media type is set when any sub-page (all, image, audio, video) mounts. This means that the code is repeated in each sub-page, and each sub-page needs to call Vuex store.

Description

The detection of search type can happen on each route change within the search page.

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Oct 26, 2021
@obulat obulat self-assigned this Oct 26, 2021
@obulat obulat mentioned this issue Oct 26, 2021
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@obulat obulat

Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move setting search type from subpages into the search page WordPress/openverse-frontend
1 participant
@obulat