Malformed variable interpolation for translations

[sarayourfriend]

Description

Something is wrong with the translated pot -> json pipeline. Some variable interpolations are not working as expected

Reproduction

Switch to German and create a query with no results (like kingfisher with the source filtered to thingiverse) and note the malformed variable interpolation resulting in ###query### displaying on the screen.

Expectation

Variable interpolations should all be transformed from the POT format to the format that VueI18n understands.

Resolution

• 🙋 I would be interested in resolving this bug.

[zackkrida]

Thank you for finding this @sarayourfriend

[0kyn]

Hi @sarayourfriend,

It might be a similar issue spotted by @zackkrida. - somehow related

The problem seems to come from Wordpress translation project:

Link to filter

[obulat]

@0kyn, GlotPress WordPress translation project uses the ###placeholder### syntax to mark the words that do not need translation. We convert the placeholders that we use in Vue's json English file (that are in form phrase with a {placeholder}) into the syntax that is used by GlotPress (phrase with a ###placeholder###) before loading the strings to GlotPress. Then we get the translations back, and convert them into the original Vue placeholder format.

The bug is caused by not using g global flag in the regex that we use to replace the placeholders. So, if there are more than one placeholders in a string, only the first one gets replaced.

[0kyn]

I got it, thank you @obulat! I took a wrong track... 😅