Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[Bug] Frontend fails to run if translations aren't fetched first #298

Closed
1 task
sarayourfriend opened this issue Oct 6, 2021 · 2 comments · Fixed by #367
Closed
1 task

[Bug] Frontend fails to run if translations aren't fetched first #298

sarayourfriend opened this issue Oct 6, 2021 · 2 comments · Fixed by #367
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@sarayourfriend
Copy link
Contributor

Description

Sometimes new translations will be available for the frontend but if you don't run i18n:get-translations before running npm run dev the API will crash after building.

Reproduction

  1. Checkout the repository and delete a translation .json file
  2. Run npm run dev
  3. See error about missing translation files

Expectation

Missing translations shouldn't crash the server

Additional context

Expectation according to @zackkrida

Resolution

  • 🙋 I would be interested in resolving this bug.
@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase labels Oct 6, 2021
@0kyn
Copy link
Contributor

0kyn commented Oct 13, 2021

Hello @sarayourfriend, it might not help but i18n:get-translations has been removed in the following commit e94c0f9

@sarayourfriend
Copy link
Contributor Author

@0kyn yeah, I think it was removed because getting translations isn't meant to be a pre-requisite for running the site locally. Correct me if I'm wrong though @zackkrida

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants