Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[Bug] Fix active filter display on medium screens #269

Closed
3 tasks
zackkrida opened this issue Sep 28, 2021 · 3 comments · Fixed by #319
Closed
3 tasks

[Bug] Fix active filter display on medium screens #269

zackkrida opened this issue Sep 28, 2021 · 3 comments · Fixed by #319
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix

Comments

@zackkrida
Copy link
Member

zackkrida commented Sep 28, 2021

Description

When on medium-ish viewports, the text in the 'active filters row' takes up multiple lines and looks terrible!

Screenshot

CleanShot 2021-09-28 at 09 13 32@2x

Solution

For our current transitional styles, let's fix this in the following way:

  • Enable flex-wrap so the tags can take up multiple rows
  • Make sure lines within the tags or label do not wrap and take up multiple lines, for any reason.
  • Remove margin-based spacing between tags and switch to a gap of .5rem (or whatever the closest unit in our spacing system is

This should give us the following result:

CleanShot 2021-10-08 at 14 08 32@2x

@zackkrida zackkrida added 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Sep 28, 2021
@fcoveram
Copy link

I like solution 1, but I also wonder how it might look like when having the tags as single lines and multiple rows, instead of the scroll bar.

In the case of Smithsonian Institutions, have we considered eliminating Smithsonian Institution text in the source since it is visible as Provider. It looks redundant and not providing much information as in the example below.

Screen Shot 2021-09-29 at 09 07 31

@zackkrida
Copy link
Member Author

I would be interested in shortening and simplifying those Smithsonian tags, definitely!

@zackkrida
Copy link
Member Author

@sarayourfriend this is ready for work, and would be nice to complete by sometime next week, at which point I intend to redeploy the frontend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants