Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Random Audio waveforms make testing them indeterminate #1494

Closed
1 task done
obulat opened this issue Jun 8, 2022 · 0 comments · Fixed by #1496
Closed
1 task done

Random Audio waveforms make testing them indeterminate #1494

obulat opened this issue Jun 8, 2022 · 0 comments · Fixed by #1496
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon

Comments

@obulat
Copy link
Contributor

obulat commented Jun 8, 2022

Problem

Currently, if the API does not return peaks for audio, we create an array of random values for the waveform. This makes it impossible to have visual regression tests for the audio detail page because the waveforms will always be different.

Description

We can use prng with a seed of audio id to make sure that each audio will always have the same waveform.

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Jun 8, 2022
@obulat obulat added this to the Full E2E Test Suite milestone Jun 8, 2022
@obulat obulat self-assigned this Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant