Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Very short audio tracks have misaligned progress bar upon track completion #1304

Closed
1 task
sarayourfriend opened this issue Apr 20, 2022 · 0 comments · Fixed by #1476
Closed
1 task

Very short audio tracks have misaligned progress bar upon track completion #1304

sarayourfriend opened this issue Apr 20, 2022 · 0 comments · Fixed by #1476
Assignees
@obulat
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Milestone
Remove Audio's 'B...

Comments

@sarayourfriend
Copy link
Contributor

Description

Example: https://search-staging.openverse.engineering/audio/d4c5806f-1e86-4f41-835f-8fcda6c62cb7

The issue is very slight but it is there.

Originally reported by @zackkrida

Reproduction

  1. Visit https://search-staging.openverse.engineering/audio/d4c5806f-1e86-4f41-835f-8fcda6c62cb7 and play the track through to the end, note the slight misalignment of the progress bar at the end.

Screenshots

image

Additional context

We could potentially solve this by setting the progress bar width to exactly 100% of the waveform width once the track completes. This seems like it's probably a rounding error.

Resolution

  • 🙋 I would be interested in resolving this bug.
@sarayourfriend sarayourfriend added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Apr 20, 2022
@obulat obulat self-assigned this May 29, 2022
@obulat obulat mentioned this issue May 29, 2022
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@obulat obulat

Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Milestone
Remove Audio's 'Beta' status
Development

Successfully merging a pull request may close this issue.

Fix waveform misalignment for short audios WordPress/openverse-frontend
3 participants
@zackkrida @obulat @sarayourfriend