Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

If there are 0 audio results on the All Content view (but some images), the Load more button is not clickable #1301

Closed
1 task
sarayourfriend opened this issue Apr 20, 2022 · 8 comments · Fixed by #1238
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟥 priority: critical Must be addressed ASAP

Comments

@sarayourfriend
Copy link
Contributor

Description

Example: https://search-staging.openverse.engineering/search/?q=%F0%9F%90%88

Go to that search and try to use the load more button, it is unresponsive.

Originally reported by @obulat

Resolution

  • 🙋 I would be interested in resolving this bug.
@sarayourfriend sarayourfriend added good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Apr 20, 2022
@godwin-olele
Copy link

Hi @sarayourfriend , the issue is that, the button has been set to disabled . inpect on the load more button , go to the html , you will see as below , try editing the html by removing the disbaled , then try it out it will load .the after that you can change that setting in your html code or css
image

@godwin-olele
Copy link

@sarayourfriend
Copy link
Contributor Author

@Godwindaniel10 yup! The reason why the button is disabled in that situation is the real question we need to answer to solve the issue 🙂 If you want to debug the issue I'd suggest looking at the VLoadMore component.

@godwin-olele
Copy link

godwin-olele commented Apr 20, 2022

@sarayourfriend aye aye, let me try checking it out

@godwin-olele
Copy link

@sarayourfriend guess im finding it had to run dev server, i followed the readme intruc

@obulat
Copy link
Contributor

obulat commented Apr 20, 2022

Oh, the problem wasn't in the emoji! 'Load More' button is disabled when there are 0 audio results, but some image results on the All Content view. #1238 could possibly fix this issue.

@obulat obulat changed the title If you search for an emoji, the Load more button is not clickable If there are 0 audio results on the All Content view (but some images), the Load more button is not clickable Apr 20, 2022
@sarayourfriend
Copy link
Contributor Author

Aaaa a classic red herring 🙂 Thanks @obulat, and for updating the title!

@obulat
Copy link
Contributor

obulat commented Apr 20, 2022

Oh, I checked #1238, and it indeed fixes this issue. I merged main into it and marked it ready for review.

@krysal krysal added 🟥 priority: critical Must be addressed ASAP and removed good first issue New-contributor friendly 🟨 priority: medium Not blocking but should be addressed soon labels Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟥 priority: critical Must be addressed ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants