Create a ~/types directory to store shared types and move types out of ~/models into the new directory

[sarayourfriend]

Problem

We've been putting most of the shared types for the app into the ~/stores/types.ts module. This module is getting long and complicated. It'd be nice to split it into smaller modules and place them in a top-level ~/types directory.

Description

Split ~/stores/types.ts into several smaller modules placed in a new ~/types directory. Additionally export types from an ~/types/index.ts so that it's easy to import types from a single import instead of having to reach for the specific module.

As @dhruvkb pointed out there is an already existing ~/models directory. The types from there should be moved into ~/types and merged with the other types.

Implementation

• 🙋 I would be interested in implementing this feature.

[dhruvkb]

@sarayourfriend some of my PRs have used the models/ directory to put shared interfaces (sorry if that's anti-conventional, I was coming at this from a Django-PoV). Should we update the issue to go ahead with models/ or move the existing code to types/?

[sarayourfriend]

types matches the package.json key for a package's type root as well as the @types prefix for definitely typed packages. I think it matches TypeScript more. But open to whatever the team wants to do, if folks like models more.

To me models reads more like database models (like something we'd use to connect to an ORM specifically) not just types that don't have any runtime implications.

[dhruvkb]

The main reasoning behind the models/ name was that it started out with the same classes that API has in its models, namely Media, Audio etc. But yeah, I agree that types/ makes more sense. So the scope of the issue should be expanded to rename the models/ directory to types/.