Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Style update of translation and news banners #1123

Closed
fcoveram opened this issue Mar 15, 2022 · 4 comments · Fixed by #1184
Closed

Style update of translation and news banners #1123

fcoveram opened this issue Mar 15, 2022 · 4 comments · Fixed by #1184
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon

Comments

@fcoveram
Copy link

Problem

As noticed in a #904's comment by @zackkrida, the translation and News banners have styles that look clunky and broken on mobile. The yellow background of News banner makes the page feel cut by the translation one.

Description

Desktop Mobile
image image

The proposal above has the following changes:

  • Background change of News banner, from brand yellow to Blue 1 (#3E58E1) from News redesign.
  • New close action on the far-right area on both banners.
  • Both banners have 16px 24px for paddings on both desktop and mobile.
  • On desktop, texts are label regular.
  • On mobile, the close action is center aligned and texts are caption regular.

Regarding banners behavior, I think both elements should show over the page instead of pushing downward the homepage main content. In that way, closing the banners do not move the page upwards.

@fcoveram fcoveram added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Mar 15, 2022
@fcoveram fcoveram added 🟨 priority: medium Not blocking but should be addressed soon and removed 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Mar 15, 2022
@sarayourfriend sarayourfriend self-assigned this Mar 22, 2022
@sarayourfriend
Copy link
Contributor

Regarding banners behavior, I think both elements should show over the page instead of pushing downward the homepage main content. In that way, closing the banners do not move the page upwards.

How would this work on the search pages? The banners would cover the header...

@zackkrida
Copy link
Member

@sarayourfriend my guess would be that he's only referring to the desktop homepage, but I still think it would be too much trouble to switch to that behavior, and only for modest gains in reducing layout shifting in one limited context (the desktop homepage).

@fcoveram
Copy link
Author

fcoveram commented Apr 5, 2022

Yes, I was referring only to the homepage.

For all internal pages, related or not to the searching experience, I remember a PR by @obulat where the translation banner does push the content downwards, not overlapping any content. That solution worked perfectly.

However, I think the News banner should be only in the homepage.

@sarayourfriend
Copy link
Contributor

Okay, thanks for the clarification @panchovm!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants