Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Teleport targets still causing crashes #1078

Closed
1 task
sarayourfriend opened this issue Mar 8, 2022 · 0 comments · Fixed by #1716
Closed
1 task

Teleport targets still causing crashes #1078

sarayourfriend opened this issue Mar 8, 2022 · 0 comments · Fixed by #1716
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@sarayourfriend
Copy link
Contributor

Description

The teleport targets are still causing crashes despite the changes in https://sentry.io/share/issue/cfcbe6bb144445a4918c77fd288516d3/

Reproduction

Not sure how to reproduce this anymore but it does appear to be uncommon.

Additional context

For scroll-to-top button I believe we can continue the forceDestroy pattern to just let the targets auto destroy on unmount instead of raising an error.

Resolution

  • 🙋 I would be interested in resolving this bug.
@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Mar 8, 2022
@obulat obulat mentioned this issue May 12, 2022
Closed
1 task
@obulat obulat mentioned this issue Aug 22, 2022
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use vue-portal for VTeleport WordPress/openverse-frontend
1 participant
@sarayourfriend