From fc28dd00bc6a97915c544cde95dc46158a185712 Mon Sep 17 00:00:00 2001
From: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Date: Wed, 2 Feb 2022 06:50:52 -0500
Subject: [PATCH] Make audio/image pages without ids show a 404 (#768)

---
 src/components/VFourOhFour.vue | 130 +++++++++++++++++++++++++++++++++
 src/layouts/error.vue          | 123 +------------------------------
 src/pages/audio/index.vue      |  11 +++
 src/pages/image/index.vue      |  11 +++
 4 files changed, 156 insertions(+), 119 deletions(-)
 create mode 100644 src/components/VFourOhFour.vue
 create mode 100644 src/pages/audio/index.vue
 create mode 100644 src/pages/image/index.vue

diff --git a/src/components/VFourOhFour.vue b/src/components/VFourOhFour.vue
new file mode 100644
index 0000000000..c015f4aeaa
--- /dev/null
+++ b/src/components/VFourOhFour.vue
@@ -0,0 +1,130 @@
+<template>
+  <main class="bg-yellow h-screen relative page-404 overflow-x-hidden">
+    <NuxtLink to="/" class="relative z-10 text-dark-charcoal">
+      <span class="sr-only">{{ $t('404.link-title') }}</span>
+      <OpenverseLogo
+        aria-hidden="true"
+        class="pt-6 lg:pt-8 ms-6 lg:ms-10 w-30 h-auto"
+      />
+    </NuxtLink>
+    <Oops
+      aria-hidden="true"
+      class="absolute opacity-5 fill-dark-charcoal -mt-[10%] -ml-[20%] lg:mx-auto w-[140%] lg:w-full px-6 lg:px-16 z-0 pointer-events-none"
+    />
+    <header
+      class="absolute lg:max-w-2xl space-y-4 lg:space-y-6 top-1/4 z-10 left-0 right-0 mx-auto px-6 lg:px-0"
+    >
+      <h1 class="mb-6 lg:mb-10 lg:leading-tight text-3xl lg:text-6xl">
+        {{ $t('404.title') }}
+      </h1>
+      <p class="font-semibold">
+        <i18n path="404.main">
+          <template #link>
+            <NuxtLink
+              class="underline text-current hover:text-current active:text-current"
+              to="/"
+            >
+              {{ $t('404.link-title') }}
+            </NuxtLink>
+          </template>
+        </i18n>
+      </p>
+      <VSearchBar
+        :value="searchTerm"
+        :label-text="$t('404.search-placeholder')"
+        field-id="404-search"
+        :placeholder="$t('404.search-placeholder')"
+        @input="setSearchTerm"
+        @submit="handleSearch"
+      />
+    </header>
+  </main>
+</template>
+
+<script>
+import {
+  defineComponent,
+  ref,
+  useContext,
+  useRouter,
+} from '@nuxtjs/composition-api'
+import { MEDIA, SEARCH } from '~/constants/store-modules'
+import { FETCH_MEDIA, UPDATE_QUERY } from '~/constants/action-types'
+
+import Oops from '~/assets/oops.svg?inline'
+import OpenverseLogo from '~/assets/logo.svg?inline'
+import VSearchBar from '~/components/VHeader/VSearchBar/VSearchBar'
+
+const VFourOhFour = defineComponent({
+  name: 'VFourOhFour',
+  components: {
+    OpenverseLogo,
+    Oops,
+    VSearchBar,
+  },
+  props: ['error'],
+  setup() {
+    const { app, store } = useContext()
+    const router = useRouter()
+
+    const searchTerm = ref('')
+    const setSearchTerm = (value) => {
+      searchTerm.value = value
+    }
+
+    const handleSearch = async () => {
+      if (searchTerm.value === '') return
+
+      await store.dispatch(`${SEARCH}/${UPDATE_QUERY}`, {
+        q: searchTerm.value,
+      })
+      await store.dispatch(`${MEDIA}/${FETCH_MEDIA}`, {
+        query: { q: searchTerm.value },
+      })
+
+      router.push(
+        app.localePath({
+          path: `/search`,
+          query: { q: searchTerm.value },
+        })
+      )
+    }
+
+    return {
+      searchTerm,
+      setSearchTerm,
+      handleSearch,
+    }
+  },
+  head: {
+    meta: [
+      {
+        hid: 'theme-color',
+        name: 'theme-color',
+        content: '#ffe033',
+      },
+    ],
+  },
+})
+export default VFourOhFour
+</script>
+
+<style>
+/* Override the default search bar styles.
+   Maybe in the future this would warrant a
+   variant of the searchbar, but that seems
+   excessive for this one-off usage.
+*/
+.page-404 .search-bar > div:not(:focus):not(:focus-within) {
+  border-color: black;
+}
+.page-404
+  .search-bar:not(:hover)
+  button:not(:hover):not(:focus):not(:focus-within) {
+  border-color: black;
+  border-inline-start-color: transparent;
+}
+.page-404 .search-bar button {
+  border-width: 1px;
+}
+</style>
diff --git a/src/layouts/error.vue b/src/layouts/error.vue
index b724b723b3..6980bca626 100644
--- a/src/layouts/error.vue
+++ b/src/layouts/error.vue
@@ -1,131 +1,16 @@
 <template>
-  <main class="bg-yellow h-screen relative page-404 overflow-x-hidden">
-    <NuxtLink to="/" class="relative z-10 text-dark-charcoal">
-      <span class="sr-only">{{ $t('404.link-title') }}</span>
-      <OpenverseLogo
-        aria-hidden="true"
-        class="pt-6 lg:pt-8 ms-6 lg:ms-10 w-30 h-auto"
-      />
-    </NuxtLink>
-    <Oops
-      aria-hidden="true"
-      class="absolute opacity-5 fill-dark-charcoal -mt-[10%] -ml-[20%] lg:mx-auto w-[140%] lg:w-full px-6 lg:px-16 z-0 pointer-events-none"
-    />
-    <header
-      class="absolute lg:max-w-2xl space-y-4 lg:space-y-6 top-1/4 z-10 left-0 right-0 mx-auto px-6 lg:px-0"
-    >
-      <h1 class="mb-6 lg:mb-10 lg:leading-tight text-3xl lg:text-6xl">
-        {{ $t('404.title') }}
-      </h1>
-      <p class="font-semibold">
-        <i18n path="404.main">
-          <template #link>
-            <NuxtLink
-              class="underline text-current hover:text-current active:text-current"
-              to="/"
-            >
-              {{ $t('404.link-title') }}
-            </NuxtLink>
-          </template>
-        </i18n>
-      </p>
-      <VSearchBar
-        :value="searchTerm"
-        :label-text="$t('404.search-placeholder')"
-        field-id="404-search"
-        :placeholder="$t('404.search-placeholder')"
-        @input="setSearchTerm"
-        @submit="handleSearch"
-      />
-    </header>
-  </main>
+  <VFourOhFour :error="error" />
 </template>
 
 <script>
-import {
-  defineComponent,
-  ref,
-  useContext,
-  useRouter,
-} from '@nuxtjs/composition-api'
-import { MEDIA, SEARCH } from '~/constants/store-modules'
-import { FETCH_MEDIA, UPDATE_QUERY } from '~/constants/action-types'
-
-import Oops from '~/assets/oops.svg?inline'
-import OpenverseLogo from '~/assets/logo.svg?inline'
-import VSearchBar from '~/components/VHeader/VSearchBar/VSearchBar'
+import { defineComponent } from '@nuxtjs/composition-api'
+import VFourOhFour from '~/components/VFourOhFour.vue'
 
 const Error = defineComponent({
   name: 'ErrorPage',
-  components: {
-    OpenverseLogo,
-    Oops,
-    VSearchBar,
-  },
+  components: { VFourOhFour },
   layout: 'blank',
   props: ['error'],
-  setup() {
-    const { app, store } = useContext()
-    const router = useRouter()
-
-    const searchTerm = ref('')
-    const setSearchTerm = (value) => {
-      searchTerm.value = value
-    }
-
-    const handleSearch = async () => {
-      if (searchTerm.value === '') return
-
-      await store.dispatch(`${SEARCH}/${UPDATE_QUERY}`, {
-        q: searchTerm.value,
-      })
-      await store.dispatch(`${MEDIA}/${FETCH_MEDIA}`, {
-        query: { q: searchTerm.value },
-      })
-
-      router.push(
-        app.localePath({
-          path: `/search`,
-          query: { q: searchTerm.value },
-        })
-      )
-    }
-
-    return {
-      searchTerm,
-      setSearchTerm,
-      handleSearch,
-    }
-  },
-  head: {
-    meta: [
-      {
-        hid: 'theme-color',
-        name: 'theme-color',
-        content: '#ffe033',
-      },
-    ],
-  },
 })
 export default Error
 </script>
-
-<style>
-/* Override the default search bar styles.
-   Maybe in the future this would warrant a
-   variant of the searchbar, but that seems
-   excessive for this one-off usage.
-*/
-.page-404 .search-bar > div:not(:focus):not(:focus-within) {
-  border-color: black;
-}
-.page-404
-  .search-bar:not(:hover)
-  button:not(:hover):not(:focus):not(:focus-within) {
-  border-color: black;
-  border-inline-start-color: transparent;
-}
-.page-404 .search-bar button {
-  border-width: 1px;
-}
-</style>
diff --git a/src/pages/audio/index.vue b/src/pages/audio/index.vue
new file mode 100644
index 0000000000..adc3a3d7bc
--- /dev/null
+++ b/src/pages/audio/index.vue
@@ -0,0 +1,11 @@
+<template><VFourOhFour /></template>
+
+<script>
+import { defineComponent } from '@vue/composition-api'
+import VFourOhFour from '~/components/VFourOhFour.vue'
+
+export default defineComponent({
+  components: { VFourOhFour },
+  layout: 'blank',
+})
+</script>
diff --git a/src/pages/image/index.vue b/src/pages/image/index.vue
new file mode 100644
index 0000000000..adc3a3d7bc
--- /dev/null
+++ b/src/pages/image/index.vue
@@ -0,0 +1,11 @@
+<template><VFourOhFour /></template>
+
+<script>
+import { defineComponent } from '@vue/composition-api'
+import VFourOhFour from '~/components/VFourOhFour.vue'
+
+export default defineComponent({
+  components: { VFourOhFour },
+  layout: 'blank',
+})
+</script>