This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Thumbnail timeouts raise TimeoutError
#695
Labels
💻 aspect: code
Concerns the software code in the repository
🛠 goal: fix
Bug fix
good first issue
New-contributor friendly
help wanted
Open to participation from the community
🟧 priority: high
Stalls work on the project or its dependents
🐍 tech: python
Requires familiarity with Python
Description
We recently changed the thumbnail service we're using and some of the business logic around it (#630). The previous thumbnail retrieval step did not have a timeout, whereas the new thumbnail retrieval step has a timeout of 5 seconds:
openverse-api/api/catalog/api/views/media_views.py
Line 173 in 03362db
We should also add a case for the
TimeoutError
exception here:openverse-api/api/catalog/api/views/media_views.py
Line 183 in 03362db
I think it might also be best for us to increase this timeout just a bit (maybe 10s?) to give the thumbnails for larger images/museum images more time to load.
Additional context
Sentry issue: https://sentry.io/share/issue/3daf5a2129a449859200e2de0c458ed6/
Resolution
The text was updated successfully, but these errors were encountered: