This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Remove bespoke throttle exemption classes and instead create a separate oauth "unlimited" scope #585
Labels
💻 aspect: code
Concerns the software code in the repository
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
🟨 priority: medium
Not blocking but should be addressed soon
Problem
I came up with the exemption class solution out of ignorance of the actual solution, which was to create a new OAuth2 scope to apply to tokens that would use an unlimited throttle.
Description
Remove the exemption classes scheme and implement the unlimited scope as a new oauth scope and apply the scope to the relevant API keys.
Note: first apply the scope the API keys in production that need it then deploy the change to add the new scope. Because of the existing exemption class approach, the scope is ignored on the key so it can be safely changed without affecting the existing throttling behavior.
Alternatives
Keep the extra code (but why maintain that when there's an existing solution for it?)
Implementation
The text was updated successfully, but these errors were encountered: