Allow inserting a link with no text selected #6886
Conversation
noisysocks
added
[Type] Enhancement
noisysocks
force-pushed
the
update/default-link-text-to-the-url
branch
from
75ff93c
to
44f29c7
Compare
editor/components/rich-text/index.js
Outdated
| } ); | ||
|
|
||
| // mceInsertLink doesn't return the anchor it creates, so query for it | ||
| // using a temporary attribute |
There was a problem hiding this comment.
I stole this idea from the classic editor.
editor/components/rich-text/index.js
Outdated
| } ); | ||
|
|
||
| // Place the cursor immediately after the newly inserted link | ||
| this.editor.selection.select( anchor ); |
There was a problem hiding this comment.
Can't this be part of the transact callback?
editor/components/rich-text/index.js
Outdated
| // mceInsertLink doesn't return the anchor it creates, so query for it | ||
| // using a temporary attribute | ||
| anchor = this.editor.getBody().querySelector( '[data-wp-temp-link]' ); | ||
| anchor.removeAttribute( 'data-wp-temp-link' ); |
There was a problem hiding this comment.
I'm not quite following why it is necessary to use the temporary attribute. Can't we insert the text and element at once? So I'm guessing when the selection is collapsed, we could use editor.insertContent( '<a href="link">link</a>' ) or something like that?
There was a problem hiding this comment.
I wasn't having any luck with isCollapsed() yesterday but now when I try it it's fine—amazing what some sleep can do! I've reworked this in 4a02305ff1472d58a32e14fca6abbb01b0fea827 🙂
When creating a link with no text selected, the link should be inserted with its text set to the URL.
We can avoid the ugly data-wp-temp-link hack by using isCollapsed() and insertContent().
Fix regression where the 'Open in new window' does not work when adding a new link.
noisysocks
force-pushed
the
update/default-link-text-to-the-url
branch
from
2ceec21
to
fafe328
Compare
|
Thanks for reviewing! I reworked my approach in 7d35c92 and snuck in two bug fixes while I was at it:
|
|
Thanks for the improvement! |
Description
Closes #5960 and fixes #6900. When creating a link with no text selected, the link should be inserted with its text set to the URL.
How has this been tested?
Screenshots