From 5369ff0ed71cce636076e907ed6b6678767ed1dd Mon Sep 17 00:00:00 2001 From: James Koster Date: Thu, 25 Jul 2024 15:15:10 +0100 Subject: [PATCH 1/2] Update field line height across grid / list layouts --- packages/dataviews/src/layouts/grid/style.scss | 7 +++++++ packages/dataviews/src/layouts/list/style.scss | 5 ++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/dataviews/src/layouts/grid/style.scss b/packages/dataviews/src/layouts/grid/style.scss index 91f0e2b8a381c9..fd4f16acef6ba1 100644 --- a/packages/dataviews/src/layouts/grid/style.scss +++ b/packages/dataviews/src/layouts/grid/style.scss @@ -61,6 +61,13 @@ padding: 0 0 $grid-unit-15; } + .dataviews-view-grid__field-value:not(:empty) { + min-height: $grid-unit-30; + line-height: $grid-unit-05 * 5; + display: flex; + align-items: center; + } + .dataviews-view-grid__field { align-items: flex-start; min-height: $grid-unit-30; diff --git a/packages/dataviews/src/layouts/list/style.scss b/packages/dataviews/src/layouts/list/style.scss index 09f29a73b74d2d..5b8f764d012a22 100644 --- a/packages/dataviews/src/layouts/list/style.scss +++ b/packages/dataviews/src/layouts/list/style.scss @@ -179,7 +179,10 @@ } .dataviews-view-list__field-value { - line-height: $grid-unit-05 * 6; + min-height: $grid-unit-30; + line-height: $grid-unit-05 * 5; + display: flex; + align-items: center; } } From c53d802509a03d76f11b22a016be39633861c813 Mon Sep 17 00:00:00 2001 From: James Koster Date: Fri, 26 Jul 2024 10:50:24 +0100 Subject: [PATCH 2/2] Adjust grid field alignment method --- packages/dataviews/src/layouts/grid/style.scss | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/dataviews/src/layouts/grid/style.scss b/packages/dataviews/src/layouts/grid/style.scss index fd4f16acef6ba1..44841e7db0e19b 100644 --- a/packages/dataviews/src/layouts/grid/style.scss +++ b/packages/dataviews/src/layouts/grid/style.scss @@ -64,8 +64,7 @@ .dataviews-view-grid__field-value:not(:empty) { min-height: $grid-unit-30; line-height: $grid-unit-05 * 5; - display: flex; - align-items: center; + padding-top: $grid-unit-05 / 2; } .dataviews-view-grid__field {