From 04b81633bf875fc1a711109841e7534987a2c95f Mon Sep 17 00:00:00 2001 From: akasunil Date: Tue, 16 Jul 2024 10:26:57 +0530 Subject: [PATCH 1/8] Add color support in tag cloud block --- docs/reference-guides/core-blocks.md | 2 +- packages/block-library/src/tag-cloud/block.json | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/reference-guides/core-blocks.md b/docs/reference-guides/core-blocks.md index e796b29ff662fb..ab8657f709a38c 100644 --- a/docs/reference-guides/core-blocks.md +++ b/docs/reference-guides/core-blocks.md @@ -912,7 +912,7 @@ A cloud of your most used tags. ([Source](https://github.com/WordPress/gutenberg - **Name:** core/tag-cloud - **Category:** widgets -- **Supports:** align, interactivity (clientNavigation), spacing (margin, padding), typography (lineHeight), ~~html~~ +- **Supports:** align, color (background, gradients, link, text), interactivity (clientNavigation), spacing (margin, padding), typography (lineHeight), ~~html~~ - **Attributes:** largestFontSize, numberOfTags, showTagCounts, smallestFontSize, taxonomy ## Template Part diff --git a/packages/block-library/src/tag-cloud/block.json b/packages/block-library/src/tag-cloud/block.json index b95e02204faa29..c4d899f5d67da6 100644 --- a/packages/block-library/src/tag-cloud/block.json +++ b/packages/block-library/src/tag-cloud/block.json @@ -37,6 +37,12 @@ "supports": { "html": false, "align": true, + "color": { + "text": true, + "background": true, + "gradients": true, + "link": true + }, "spacing": { "margin": true, "padding": true From 01838c6af212fed668555acade7800da01d7e9fb Mon Sep 17 00:00:00 2001 From: akasunil Date: Wed, 17 Jul 2024 14:05:56 +0530 Subject: [PATCH 2/8] Excluding text support from tag cloud block --- packages/block-library/src/tag-cloud/block.json | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/block-library/src/tag-cloud/block.json b/packages/block-library/src/tag-cloud/block.json index c4d899f5d67da6..9770565faf655b 100644 --- a/packages/block-library/src/tag-cloud/block.json +++ b/packages/block-library/src/tag-cloud/block.json @@ -38,7 +38,6 @@ "html": false, "align": true, "color": { - "text": true, "background": true, "gradients": true, "link": true From 19784ff2ecea673fa5611a1a9cdc61d6ccc90ecd Mon Sep 17 00:00:00 2001 From: akasunil Date: Thu, 18 Jul 2024 14:01:32 +0530 Subject: [PATCH 3/8] Exclude text support from tag cloud block --- packages/block-library/src/tag-cloud/block.json | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/block-library/src/tag-cloud/block.json b/packages/block-library/src/tag-cloud/block.json index 9770565faf655b..73665301fe525d 100644 --- a/packages/block-library/src/tag-cloud/block.json +++ b/packages/block-library/src/tag-cloud/block.json @@ -39,6 +39,7 @@ "align": true, "color": { "background": true, + "text": false, "gradients": true, "link": true }, From 40be3a1955e79189de1b9177bcb28fe9df35bdec Mon Sep 17 00:00:00 2001 From: akasunil Date: Thu, 18 Jul 2024 14:20:22 +0530 Subject: [PATCH 4/8] Update developer docs --- docs/reference-guides/core-blocks.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/reference-guides/core-blocks.md b/docs/reference-guides/core-blocks.md index a6148498b649cc..d09901b07e90d1 100644 --- a/docs/reference-guides/core-blocks.md +++ b/docs/reference-guides/core-blocks.md @@ -912,7 +912,7 @@ A cloud of your most used tags. ([Source](https://github.com/WordPress/gutenberg - **Name:** core/tag-cloud - **Category:** widgets -- **Supports:** align, color (background, gradients, link, text), interactivity (clientNavigation), spacing (margin, padding), typography (lineHeight), ~~html~~ +- **Supports:** align, color (background, gradients, link, ~~text~~), interactivity (clientNavigation), spacing (margin, padding), typography (lineHeight), ~~html~~ - **Attributes:** largestFontSize, numberOfTags, showTagCounts, smallestFontSize, taxonomy ## Template Part From e964441a9ad8bbcb1dc5caf9aabd4f335409d527 Mon Sep 17 00:00:00 2001 From: akasunil Date: Fri, 9 Aug 2024 17:56:32 +0530 Subject: [PATCH 5/8] Remove skipblockSupportAttributes --- packages/block-library/src/tag-cloud/edit.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/block-library/src/tag-cloud/edit.js b/packages/block-library/src/tag-cloud/edit.js index 9a2b531b30f8ab..1c1f27b3c20fef 100644 --- a/packages/block-library/src/tag-cloud/edit.js +++ b/packages/block-library/src/tag-cloud/edit.js @@ -186,7 +186,6 @@ function TagCloudEdit( { attributes, setAttributes } ) {
From cb3360f1de6b75d9efddf977672d65f1d2a6e2b7 Mon Sep 17 00:00:00 2001 From: akasunil Date: Tue, 13 Aug 2024 12:08:59 +0530 Subject: [PATCH 6/8] Fix delay in background update and resolve gradient issue --- packages/block-library/src/tag-cloud/edit.js | 1 + packages/block-library/src/tag-cloud/editor.scss | 2 ++ 2 files changed, 3 insertions(+) diff --git a/packages/block-library/src/tag-cloud/edit.js b/packages/block-library/src/tag-cloud/edit.js index b11afd3fd9da52..dfa00061c27d81 100644 --- a/packages/block-library/src/tag-cloud/edit.js +++ b/packages/block-library/src/tag-cloud/edit.js @@ -113,6 +113,7 @@ function TagCloudEdit( { attributes, setAttributes } ) { style: { ...attributes?.style, border: undefined, + color: undefined, }, }; diff --git a/packages/block-library/src/tag-cloud/editor.scss b/packages/block-library/src/tag-cloud/editor.scss index d00a450174f2fd..5a343c5e7c0d3f 100644 --- a/packages/block-library/src/tag-cloud/editor.scss +++ b/packages/block-library/src/tag-cloud/editor.scss @@ -8,4 +8,6 @@ padding: 0; border: none; border-radius: inherit; + // Using important to override global styles. + background: inherit ! important; } From ee63378ade1b6351c9bcdd68ec6ae2c6042d99a1 Mon Sep 17 00:00:00 2001 From: akasunil Date: Tue, 13 Aug 2024 14:37:30 +0530 Subject: [PATCH 7/8] Fix linting errors --- packages/block-library/src/tag-cloud/editor.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-library/src/tag-cloud/editor.scss b/packages/block-library/src/tag-cloud/editor.scss index 5a343c5e7c0d3f..8001169900eaa8 100644 --- a/packages/block-library/src/tag-cloud/editor.scss +++ b/packages/block-library/src/tag-cloud/editor.scss @@ -9,5 +9,5 @@ border: none; border-radius: inherit; // Using important to override global styles. - background: inherit ! important; + background: inherit !important; } From 2834168bdeb4c035e83556a7069b78640db9cbc3 Mon Sep 17 00:00:00 2001 From: akasunil Date: Tue, 13 Aug 2024 22:28:44 +0530 Subject: [PATCH 8/8] Update styles of tag cloud block to inherit global styles --- packages/block-library/src/tag-cloud/editor.scss | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/block-library/src/tag-cloud/editor.scss b/packages/block-library/src/tag-cloud/editor.scss index 8001169900eaa8..609320205ff7bd 100644 --- a/packages/block-library/src/tag-cloud/editor.scss +++ b/packages/block-library/src/tag-cloud/editor.scss @@ -8,6 +8,5 @@ padding: 0; border: none; border-radius: inherit; - // Using important to override global styles. - background: inherit !important; + background: inherit; }