Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate on 'Insert link' interface #6028

Merged
merged 9 commits into from
Apr 10, 2018
Merged

Iterate on 'Insert link' interface #6028

merged 9 commits into from
Apr 10, 2018

Commits on Apr 9, 2018

  1. Revert "Remove "Open in new window" link option (#4583)" 

    This reverts commit 5ab37b7.
    @noisysocks
    noisysocks committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    eb2454d View commit details
    Browse the repository at this point in the history

  2. Fix 'Open in new window' link option 

    Some changes had occured elsewhere in the codebase in between when this
UI was reverted and when it was unreverted.

- Imports `ToggleControl` correctly
- Fixes `RichText` tests
    @noisysocks
    noisysocks committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    f46cd44 View commit details
    Browse the repository at this point in the history

  3. Use ellipsis icon for opening link settings 

    Change the icon to be the same icon used elsewhere in the editor, and
move the toggle button to the left of the link UI.
    @noisysocks
    noisysocks committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    b12be5b View commit details
    Browse the repository at this point in the history

  4. Use link toolbar button to remove links 

    Consolidate the dedicated 'remove link' button into the toolbar button
that adds a link.
    @noisysocks
    noisysocks committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    5f916d7 View commit details
    Browse the repository at this point in the history

  5. After editing a link, exit editing mode 

    Reset the link UI once the user has edited the link value.
    @noisysocks
    noisysocks committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    4a9ff7a View commit details
    Browse the repository at this point in the history

  6. Fix error when setting 'Open in new window' on a new link 

    Don't call `onChange()` when 'Open in new window' is toggled if we are
adding a new link (as opposed to editing an existing link).
    @noisysocks
    noisysocks committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    d111047 View commit details
    Browse the repository at this point in the history

  7. Expand link UI to fit contents 

    The link popup should widen to fit the URL within it.
    @noisysocks
    noisysocks committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    8e64f33 View commit details
    Browse the repository at this point in the history

  8. Improve suggested links UI in link inserter 

    Make the suggested links UI more stylistically consistent with the rest
of the editor.
    @noisysocks
    noisysocks committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    94ab326 View commit details
    Browse the repository at this point in the history

  9. Move settings button to right of the link UI 

    Move the ellipsis button to the right of the edit button. This is more
consistent with where the ellipsis icon is used elsewhere in the editor.
    @noisysocks
    noisysocks committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    0bb6c85 View commit details
    Browse the repository at this point in the history