From 9e11bd92d4403cbf8fe8c9b2230ef8b3f2803c25 Mon Sep 17 00:00:00 2001
From: Grant Kinney <hi@grant.mk>
Date: Thu, 22 Feb 2024 14:21:13 -0600
Subject: [PATCH 01/19] Adds meta cap for upload_fonts and gates REST API font
 uploads

---
 .../class-wp-rest-font-faces-controller.php   |  8 +++++
 lib/compat/wordpress-6.5/fonts/fonts.php      | 29 +++++++++++++++++++
 2 files changed, 37 insertions(+)

diff --git a/lib/compat/wordpress-6.5/fonts/class-wp-rest-font-faces-controller.php b/lib/compat/wordpress-6.5/fonts/class-wp-rest-font-faces-controller.php
index 8a4040e3397e0..cb89b5ad3c84b 100644
--- a/lib/compat/wordpress-6.5/fonts/class-wp-rest-font-faces-controller.php
+++ b/lib/compat/wordpress-6.5/fonts/class-wp-rest-font-faces-controller.php
@@ -326,6 +326,14 @@ public function create_item( $request ) {
 			$settings    = $request->get_param( 'font_face_settings' );
 			$file_params = $request->get_file_params();
 
+			if ( ! empty( $file_params ) && ! current_user_can( 'upload_fonts' ) ) {
+				return new WP_Error(
+					'rest_cannot_upload_fonts',
+					__( 'You are not allowed to upload font files.', 'gutenberg' ),
+					array( 'status' => 403 )
+				);
+			}
+
 			// Check that the necessary font face properties are unique.
 			$query = new WP_Query(
 				array(
diff --git a/lib/compat/wordpress-6.5/fonts/fonts.php b/lib/compat/wordpress-6.5/fonts/fonts.php
index 8307d5217ad42..36a44e8b0f6cf 100644
--- a/lib/compat/wordpress-6.5/fonts/fonts.php
+++ b/lib/compat/wordpress-6.5/fonts/fonts.php
@@ -84,6 +84,35 @@ function gutenberg_create_initial_post_types() {
 	);
 }
 
+/**
+ * Filters the user capabilities to grant the 'upload_fonts' capability as necessary.
+ *
+ * To grant the 'upload_fonts' capability, files modifications must be allowed, the fonts directory must be
+ * writable, and the user must have the 'edit_theme_options' capability.
+ *
+ * @since 5.6.0
+ *
+ * @param bool[] $allcaps An array of all the user's capabilities.
+ * @return bool[] Filtered array of the user's capabilities.
+ */
+function gutenberg_maybe_grant_upload_font_cap( $allcaps, $caps ) {
+	if ( ! in_array( 'upload_fonts', $caps, true ) ) {
+		return $allcaps;
+	}
+
+	$fonts_dir = wp_get_font_dir()['path'];
+	if (
+		wp_is_file_mod_allowed( 'can_upload_fonts' ) &&
+		wp_is_writable( $fonts_dir ) &&
+		! empty( $allcaps['edit_theme_options'] )
+	) {
+		$allcaps['upload_fonts'] = true;
+	}
+
+	return $allcaps;
+}
+add_filter( 'user_has_cap', 'gutenberg_maybe_grant_upload_font_cap', 10, 2 );
+
 /**
  * Initializes REST routes.
  *

From 7846623da8454a7b5c4c1b488da3a4d39917d78a Mon Sep 17 00:00:00 2001
From: Grant Kinney <hi@grant.mk>
Date: Thu, 22 Feb 2024 15:36:22 -0600
Subject: [PATCH 02/19] Shows/hides font upload and install tabs according to
 user capabilities

---
 lib/compat/wordpress-6.5/fonts/fonts.php      | 15 +++++++
 .../global-styles/font-library-modal/index.js | 42 ++++++++++++-------
 packages/editor/src/store/defaults.js         |  2 +
 3 files changed, 45 insertions(+), 14 deletions(-)

diff --git a/lib/compat/wordpress-6.5/fonts/fonts.php b/lib/compat/wordpress-6.5/fonts/fonts.php
index 36a44e8b0f6cf..04c0b1666dd1b 100644
--- a/lib/compat/wordpress-6.5/fonts/fonts.php
+++ b/lib/compat/wordpress-6.5/fonts/fonts.php
@@ -332,6 +332,21 @@ function _wp_before_delete_font_face( $post_id, $post ) {
 	add_action( 'before_delete_post', '_wp_before_delete_font_face', 10, 2 );
 }
 
+/**
+ * Filters the block editor settings to enable or disable font uploads according to user capability.
+ *
+ * @since 6.5.0
+ *
+ * @param array $settings Block editor settings.
+ * @return array Block editor settings.
+ */
+function gutenberg_font_uploads_settings( $settings ) {
+	$settings['fontUploadsEnabled'] = current_user_can( 'upload_fonts' );
+
+	return $settings;
+}
+add_filter( 'block_editor_settings_all', 'gutenberg_font_uploads_settings' );
+
 // @core-merge: Do not merge this back compat function, it is for supporting a legacy font family format only in Gutenberg.
 /**
  * Convert legacy font family posts to the new format.
diff --git a/packages/edit-site/src/components/global-styles/font-library-modal/index.js b/packages/edit-site/src/components/global-styles/font-library-modal/index.js
index dc0fcd7ea373b..ff77f6dde53c3 100644
--- a/packages/edit-site/src/components/global-styles/font-library-modal/index.js
+++ b/packages/edit-site/src/components/global-styles/font-library-modal/index.js
@@ -6,6 +6,9 @@ import {
 	Modal,
 	privateApis as componentsPrivateApis,
 } from '@wordpress/components';
+import { store as coreStore } from '@wordpress/core-data';
+import { useSelect } from '@wordpress/data';
+import { store as editorStore } from '@wordpress/editor';
 import { useContext } from '@wordpress/element';
 
 /**
@@ -19,16 +22,15 @@ import { unlock } from '../../../lock-unlock';
 
 const { Tabs } = unlock( componentsPrivateApis );
 
-const DEFAULT_TABS = [
-	{
-		id: 'installed-fonts',
-		title: __( 'Library' ),
-	},
-	{
-		id: 'upload-fonts',
-		title: __( 'Upload' ),
-	},
-];
+const DEFAULT_TAB = {
+	id: 'installed-fonts',
+	title: __( 'Library' ),
+};
+
+const UPLOAD_TAB = {
+	id: 'upload-fonts',
+	title: __( 'Upload' ),
+};
 
 const tabsFromCollections = ( collections ) =>
 	collections.map( ( { slug, name } ) => ( {
@@ -44,11 +46,23 @@ function FontLibraryModal( {
 	defaultTabId = 'installed-fonts',
 } ) {
 	const { collections, setNotice } = useContext( FontLibraryContext );
+	const canUserCreate = useSelect( ( select ) => {
+		const { canUser } = select( coreStore );
+		return canUser( 'create', 'font-families' );
+	}, [] );
+	const fontUploadsEnabled = useSelect( ( select ) => {
+		const { getEditorSettings } = select( editorStore );
+		return getEditorSettings().fontUploadsEnabled;
+	}, [] );
+
+	const tabs = [ DEFAULT_TAB ];
 
-	const tabs = [
-		...DEFAULT_TABS,
-		...tabsFromCollections( collections || [] ),
-	];
+	if ( canUserCreate && fontUploadsEnabled ) {
+		tabs.push( UPLOAD_TAB );
+		// In the future, font faces can be configured to use a remote url rather than a file upload as the font src property.
+		// In that case, collections tabs should still be shown when font uploads are disabled.
+		tabs.push( ...tabsFromCollections( collections || [] ) );
+	}
 
 	// Reset notice when new tab is selected.
 	const onSelect = () => {
diff --git a/packages/editor/src/store/defaults.js b/packages/editor/src/store/defaults.js
index e4f86b3a7dfb2..1eac4c726ddd3 100644
--- a/packages/editor/src/store/defaults.js
+++ b/packages/editor/src/store/defaults.js
@@ -10,6 +10,7 @@ import { SETTINGS_DEFAULTS } from '@wordpress/block-editor';
  * @property {boolean}       richEditingEnabled    Whether rich editing is enabled or not
  * @property {boolean}       codeEditingEnabled    Whether code editing is enabled or not
  * @property {boolean}       fontLibraryEnabled    Whether the font library is enabled or not.
+ * @property {boolean}       fontUploadsEnabled    Whether uploading fonts in the font library is enabled or not.
  * @property {boolean}       enableCustomFields    Whether the WordPress custom fields are enabled or not.
  *                                                 true  = the user has opted to show the Custom Fields panel at the bottom of the editor.
  *                                                 false = the user has opted to hide the Custom Fields panel at the bottom of the editor.
@@ -28,6 +29,7 @@ export const EDITOR_SETTINGS_DEFAULTS = {
 	richEditingEnabled: true,
 	codeEditingEnabled: true,
 	fontLibraryEnabled: true,
+	fontUploadsEnabled: true,
 	enableCustomFields: undefined,
 	defaultRenderingMode: 'post-only',
 };

From 314cad63ef0503c79706cc9264c0da478ec6c32f Mon Sep 17 00:00:00 2001
From: Grant Kinney <hi@grant.mk>
Date: Thu, 22 Feb 2024 16:16:21 -0600
Subject: [PATCH 03/19] Prevents deleting fonts if user lacks capability

---
 .../font-library-modal/installed-fonts.js     | 20 ++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/packages/edit-site/src/components/global-styles/font-library-modal/installed-fonts.js b/packages/edit-site/src/components/global-styles/font-library-modal/installed-fonts.js
index 99c99e44a43af..bcd37a18cebad 100644
--- a/packages/edit-site/src/components/global-styles/font-library-modal/installed-fonts.js
+++ b/packages/edit-site/src/components/global-styles/font-library-modal/installed-fonts.js
@@ -12,6 +12,8 @@ import {
 	Spinner,
 	FlexItem,
 } from '@wordpress/components';
+import { store as coreStore } from '@wordpress/core-data';
+import { useSelect } from '@wordpress/data';
 
 /**
  * Internal dependencies
@@ -38,6 +40,20 @@ function InstalledFonts() {
 	} = useContext( FontLibraryContext );
 	const [ isConfirmDeleteOpen, setIsConfirmDeleteOpen ] = useState( false );
 
+	const customFontFamilyId =
+		libraryFontSelected?.source === 'custom' && libraryFontSelected?.id;
+
+	const canUserDelete = useSelect(
+		( select ) => {
+			const { canUser } = select( coreStore );
+			return (
+				customFontFamilyId &&
+				canUser( 'delete', 'font-families', customFontFamilyId )
+			);
+		},
+		[ customFontFamilyId ]
+	);
+
 	const handleUnselectFont = () => {
 		handleSetLibraryFontSelected( null );
 	};
@@ -84,7 +100,9 @@ function InstalledFonts() {
 		: null;
 
 	const shouldDisplayDeleteButton =
-		!! libraryFontSelected && libraryFontSelected?.source !== 'theme';
+		!! libraryFontSelected &&
+		libraryFontSelected?.source !== 'theme' &&
+		canUserDelete;
 
 	useEffect( () => {
 		handleSelectFont( libraryFontSelected );

From efa01ec1c09d8b4ab73406dc1816146e57870eae Mon Sep 17 00:00:00 2001
From: Grant Kinney <hi@grant.mk>
Date: Thu, 22 Feb 2024 16:47:31 -0600
Subject: [PATCH 04/19] Fixes comment block

---
 lib/compat/wordpress-6.5/fonts/fonts.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/compat/wordpress-6.5/fonts/fonts.php b/lib/compat/wordpress-6.5/fonts/fonts.php
index 04c0b1666dd1b..833b9f72273e0 100644
--- a/lib/compat/wordpress-6.5/fonts/fonts.php
+++ b/lib/compat/wordpress-6.5/fonts/fonts.php
@@ -87,10 +87,10 @@ function gutenberg_create_initial_post_types() {
 /**
  * Filters the user capabilities to grant the 'upload_fonts' capability as necessary.
  *
- * To grant the 'upload_fonts' capability, files modifications must be allowed, the fonts directory must be
+ * To grant the 'upload_fonts' capability, file modifications must be allowed, the fonts directory must be
  * writable, and the user must have the 'edit_theme_options' capability.
  *
- * @since 5.6.0
+ * @since 6.5.0
  *
  * @param bool[] $allcaps An array of all the user's capabilities.
  * @return bool[] Filtered array of the user's capabilities.

From dc57cd4c1bf1ffe96d287082aace09f8e5b040a4 Mon Sep 17 00:00:00 2001
From: Matias Benedetto <matias.benedetto@gmail.com>
Date: Fri, 23 Feb 2024 14:00:20 -0300
Subject: [PATCH 05/19] Display the font collection tabs when user can create
 font families. Disable upload tab when the user can't write font face assets.
 Disallow install button when the user can write font faces and the selected
 font has font faces

---
 .../font-library-modal/font-collection.js       | 17 +++++++++++++++--
 .../global-styles/font-library-modal/index.js   |  9 +++++----
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/packages/edit-site/src/components/global-styles/font-library-modal/font-collection.js b/packages/edit-site/src/components/global-styles/font-library-modal/font-collection.js
index b792a5c8246c0..850b74da3d91a 100644
--- a/packages/edit-site/src/components/global-styles/font-library-modal/font-collection.js
+++ b/packages/edit-site/src/components/global-styles/font-library-modal/font-collection.js
@@ -23,6 +23,8 @@ import {
 import { debounce } from '@wordpress/compose';
 import { sprintf, __, _x } from '@wordpress/i18n';
 import { search, closeSmall } from '@wordpress/icons';
+import { useSelect } from '@wordpress/data';
+import { store as editorStore } from '@wordpress/editor';
 
 /**
  * Internal dependencies
@@ -215,6 +217,7 @@ function FontCollection( { slug } ) {
 			<InstallFooter
 				handleInstall={ handleInstall }
 				isDisabled={ fontsToInstall.length === 0 }
+				selectedFont={ selectedFont }
 			/>
 		);
 	} else if ( ! renderConfirmDialog && totalPages > 1 ) {
@@ -400,16 +403,26 @@ function PaginationFooter( { page, totalPages, setPage } ) {
 	);
 }
 
-function InstallFooter( { handleInstall, isDisabled } ) {
+function InstallFooter( { handleInstall, isDisabled, selectedFont } ) {
 	const { isInstalling } = useContext( FontLibraryContext );
 
+	const fontUploadsEnabled = useSelect( ( select ) => {
+		const { getEditorSettings } = select( editorStore );
+		return getEditorSettings().fontUploadsEnabled;
+	}, [] );
+
+	const isInstallButtonDisabled =
+		isDisabled ||
+		isInstalling ||
+		( ! fontUploadsEnabled && selectedFont?.fontFace?.length );
+
 	return (
 		<Flex justify="flex-end">
 			<Button
 				variant="primary"
 				onClick={ handleInstall }
 				isBusy={ isInstalling }
-				disabled={ isDisabled || isInstalling }
+				disabled={ isInstallButtonDisabled }
 				__experimentalIsFocusable
 			>
 				{ __( 'Install' ) }
diff --git a/packages/edit-site/src/components/global-styles/font-library-modal/index.js b/packages/edit-site/src/components/global-styles/font-library-modal/index.js
index ff77f6dde53c3..636545fa87ef2 100644
--- a/packages/edit-site/src/components/global-styles/font-library-modal/index.js
+++ b/packages/edit-site/src/components/global-styles/font-library-modal/index.js
@@ -57,10 +57,11 @@ function FontLibraryModal( {
 
 	const tabs = [ DEFAULT_TAB ];
 
-	if ( canUserCreate && fontUploadsEnabled ) {
-		tabs.push( UPLOAD_TAB );
-		// In the future, font faces can be configured to use a remote url rather than a file upload as the font src property.
-		// In that case, collections tabs should still be shown when font uploads are disabled.
+	if ( canUserCreate ) {
+		if ( fontUploadsEnabled ) {
+			tabs.push( UPLOAD_TAB );
+		}
+
 		tabs.push( ...tabsFromCollections( collections || [] ) );
 	}
 

From 84b54ed3732f2eca3ed85b192c84feb1b3199f38 Mon Sep 17 00:00:00 2001
From: Grant Kinney <hi@grant.mk>
Date: Fri, 23 Feb 2024 14:07:37 -0600
Subject: [PATCH 06/19] Check for font file upload capability before deleting
 fonts with associated font files

---
 lib/compat/wordpress-6.5/fonts/fonts.php | 86 +++++++++++++++++++++++-
 1 file changed, 85 insertions(+), 1 deletion(-)

diff --git a/lib/compat/wordpress-6.5/fonts/fonts.php b/lib/compat/wordpress-6.5/fonts/fonts.php
index 833b9f72273e0..7a876a5d697b1 100644
--- a/lib/compat/wordpress-6.5/fonts/fonts.php
+++ b/lib/compat/wordpress-6.5/fonts/fonts.php
@@ -84,6 +84,90 @@ function gutenberg_create_initial_post_types() {
 	);
 }
 
+/**
+ * Modify the `delete_post` meta capability for font post types.
+ *
+ * For font families and font faces containing attached font files, file
+ * system access is required by the user in order to delete posts.
+ *
+ * @param string[] $caps    The primitive capabilities required for the given capability.
+ * @param string   $cap     The capability being checked.
+ * @param int      $user_id The user ID.
+ * @param array    $args    Context for the capability check.
+ * @return string[] The modified primitive capabilities required for the given capability.
+ */
+function gutenberg_delete_font_post_meta_caps( $caps, $cap, $user_id, $args ) {
+	if ( in_array( 'do_not_allow', $caps, true ) ) {
+		// It's already known that the user is not allowed to perform the requested capability.
+		return $caps;
+	}
+
+	if ( 'delete_post' !== $cap ) {
+		// This filter is only concerned with the 'delete_post' meta capability.
+		return $caps;
+	}
+
+	$post = get_post( $args[0] );
+	if ( ! $post ) {
+		// Do not allow deleting posts that do not exist.
+		$caps[] = 'do_not_allow';
+		return $caps;
+	}
+
+	// Check for font post types.
+	$post_type = get_post_type( $post );
+	if ( 'wp_font_face' === $post_type ) {
+		// Are there any font files associated with this font face?
+		$font_files = get_post_meta( $post->ID, '_wp_font_face_file', false );
+		if ( empty( $font_files ) ) {
+			/*
+			* No font files.
+			*
+			* The user can delete the post based on the 'delete_post' meta capability.
+			*/
+			return $caps;
+		}
+
+		// The user can only delete the post if they can modify the file system.
+		$caps[] = 'upload_fonts';
+		return $caps;
+	}
+
+	if ( 'wp_font_family' === $post_type ) {
+		// Are there any font faces associated with this font family?
+		$font_faces = get_children(
+			array(
+				'post_parent' => $post->ID,
+				'post_type'   => 'wp_font_face',
+			)
+		);
+
+		if ( empty( $font_faces ) ) {
+			/*
+			 * No font faces.
+			 *
+			 * The user can delete the post based on the 'delete_post' meta capability.
+			 */
+			return $caps;
+		}
+
+		// If any of the font faces contain files, the user needs to be able to modify the file system.
+		foreach ( $font_faces as $font_face ) {
+			$font_files = get_post_meta( $font_face->ID, '_wp_font_face_file', false );
+			if ( ! empty( $font_files ) ) {
+				$caps[] = 'upload_fonts';
+				// File system caps are required, so no need to check further.
+				break;
+			}
+		}
+		return $caps;
+	}
+
+	// Return existing caps if the post type is not a font family or font face.
+	return $caps;
+}
+add_filter( 'map_meta_cap', 'gutenberg_delete_font_post_meta_caps', 10, 4 );
+
 /**
  * Filters the user capabilities to grant the 'upload_fonts' capability as necessary.
  *
@@ -92,7 +176,7 @@ function gutenberg_create_initial_post_types() {
  *
  * @since 6.5.0
  *
- * @param bool[] $allcaps An array of all the user's capabilities.
+ * @param  bool[] $allcaps An array of all the user's capabilities.
  * @return bool[] Filtered array of the user's capabilities.
  */
 function gutenberg_maybe_grant_upload_font_cap( $allcaps, $caps ) {

From 5fe3776073027c0ff03b1333a2e18829c4bb6a59 Mon Sep 17 00:00:00 2001
From: Grant Kinney <hi@grant.mk>
Date: Fri, 23 Feb 2024 14:30:44 -0600
Subject: [PATCH 07/19] Checks wp_font_face post type capability before adding
 upload_fonts capability

---
 lib/compat/wordpress-6.5/fonts/fonts.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/compat/wordpress-6.5/fonts/fonts.php b/lib/compat/wordpress-6.5/fonts/fonts.php
index 7a876a5d697b1..51b95558ed98c 100644
--- a/lib/compat/wordpress-6.5/fonts/fonts.php
+++ b/lib/compat/wordpress-6.5/fonts/fonts.php
@@ -185,10 +185,11 @@ function gutenberg_maybe_grant_upload_font_cap( $allcaps, $caps ) {
 	}
 
 	$fonts_dir = wp_get_font_dir()['path'];
+	$post_type = get_post_type_object( 'wp_font_face' );
 	if (
 		wp_is_file_mod_allowed( 'can_upload_fonts' ) &&
 		wp_is_writable( $fonts_dir ) &&
-		! empty( $allcaps['edit_theme_options'] )
+		current_user_can( $post_type->cap->create_posts )
 	) {
 		$allcaps['upload_fonts'] = true;
 	}
@@ -222,7 +223,7 @@ function gutenberg_init_font_library() {
 	}
 }
 
-add_action( 'rest_api_init', 'gutenberg_init_font_library' );
+add_action( 'init', 'gutenberg_init_font_library' );
 
 
 if ( ! function_exists( 'wp_register_font_collection' ) ) {

From 9867c3e83d87bce7b77946b0bbc91163c85f80d6 Mon Sep 17 00:00:00 2001
From: Grant Kinney <hi@grant.mk>
Date: Fri, 23 Feb 2024 15:37:59 -0600
Subject: [PATCH 08/19] Moves font REST API registration to correct hook

---
 lib/compat/wordpress-6.5/fonts/fonts.php | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/lib/compat/wordpress-6.5/fonts/fonts.php b/lib/compat/wordpress-6.5/fonts/fonts.php
index 51b95558ed98c..4c833f19ef90f 100644
--- a/lib/compat/wordpress-6.5/fonts/fonts.php
+++ b/lib/compat/wordpress-6.5/fonts/fonts.php
@@ -200,18 +200,21 @@ function gutenberg_maybe_grant_upload_font_cap( $allcaps, $caps ) {
 
 /**
  * Initializes REST routes.
- *
- * @since 6.5
  */
 function gutenberg_create_initial_rest_routes() {
-	$font_collections_controller = new WP_REST_Font_Collections_Controller();
-	$font_collections_controller->register_routes();
+	global $wp_version;
+
+	// Runs only if the Font Library is not available in core ( i.e. in core < 6.5-alpha ).
+	if ( version_compare( $wp_version, '6.5-alpha', '<' ) ) {
+		$font_collections_controller = new WP_REST_Font_Collections_Controller();
+		$font_collections_controller->register_routes();
+	}
 }
 
+add_action( 'rest_api_init', 'gutenberg_create_initial_rest_routes' );
+
 /**
  * Initializes REST routes and post types.
- *
- * @since 6.5
  */
 function gutenberg_init_font_library() {
 	global $wp_version;
@@ -219,7 +222,6 @@ function gutenberg_init_font_library() {
 	// Runs only if the Font Library is not available in core ( i.e. in core < 6.5-alpha ).
 	if ( version_compare( $wp_version, '6.5-alpha', '<' ) ) {
 		gutenberg_create_initial_post_types();
-		gutenberg_create_initial_rest_routes();
 	}
 }
 

From 080064443bc8fdc0551836bc1240c63477b6d5ff Mon Sep 17 00:00:00 2001
From: Anton Vlasenko <vlasenko.anton@gmail.com>
Date: Sat, 24 Feb 2024 13:01:39 +0100
Subject: [PATCH 09/19] Commit WIP

---
 .../font-library/maybeGrantUploadFontCap.php  | 91 +++++++++++++++++++
 1 file changed, 91 insertions(+)
 create mode 100644 phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php

diff --git a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
new file mode 100644
index 0000000000000..52910ebda1aea
--- /dev/null
+++ b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
@@ -0,0 +1,91 @@
+<?php
+
+class Test_Gutenberg_Maybe_Upload_Font_Cap extends WP_UnitTestCase {
+
+	/**
+	 * Mock the wp_get_font_dir function to return a valid path.
+	 *
+	 * @return string[]
+	 */
+	public function mock_wp_get_font_dir() {
+		return array( 'path' => '/valid/font/directory' );
+	}
+
+	/**
+	 * Mock the wp_is_file_mod_allowed function to return true.
+	 *
+	 * @param string $context
+	 *
+	 * @return true|void
+	 */
+	public function mock_wp_is_file_mod_allowed( $context ) {
+		if ( $context === 'can_upload_fonts' ) {
+			return true;
+		}
+	}
+
+	/**
+	 * Mock the wp_is_writable function to return true.
+	 *
+	 * @param string $path
+	 *
+	 * @return true|void
+	 */
+	public function mock_wp_is_writable( $path ) {
+		if ( $path === '/valid/font/directory' ) {
+			return true;
+		}
+	}
+
+	/**
+	 * Mock current_user_can for 'wp_font_face' post type's 'create_posts' capability to return true.
+	 *
+	 * @param string[] $caps
+	 * @param string $cap
+	 * @param int $user_id
+	 * @param array $args
+	 *
+	 * @return string[]
+	 */
+	public function mock_current_user_can( $caps, $cap, $user_id, $args ) {
+		if ( $cap === 'create_posts' && isset( $args[0] ) && $args[0] === 'wp_font_face' ) {
+			return array( 'exist' ); // The 'exist' cap is a minimal capability that all users have
+		}
+
+		return $caps;
+	}
+
+	public function set_up() {
+		parent::set_up();
+		add_filter( 'wp_get_font_dir', array( $this, 'mock_wp_get_font_dir' ) );
+		add_filter( 'wp_is_file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
+		add_filter( 'wp_is_writable', array( $this, 'mock_wp_is_writable' ) );
+		add_filter( 'map_meta_cap', array( $this, 'mock_current_user_can' ), 10, 4 );
+	}
+
+	public function tear_down() {
+		remove_filter( 'wp_get_font_dir', array( $this, 'mock_wp_get_font_dir' ) );
+		remove_filter( 'wp_is_file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
+		remove_filter( 'wp_is_writable', array( $this, 'mock_wp_is_writable' ) );
+		remove_filter( 'map_meta_cap', array( $this, 'mock_current_user_can' ), 10 );
+
+		parent::tear_down();
+	}
+
+	public function test_not_granting_upload_fonts_if_not_in_caps() {
+		$caps   = array( 'edit_posts' ); // 'upload_fonts' is not in $caps
+		$result = gutenberg_maybe_grant_upload_font_cap( array(), $caps );
+		$this->assertArrayNotHasKey( 'upload_fonts', $result, 'upload_fonts should not be granted' );
+	}
+
+	public function test_granting_upload_fonts_under_correct_conditions() {
+		// Mock necessary functions and conditions here
+		$allcaps = array();
+		$caps    = array( 'upload_fonts' );
+
+		$result = gutenberg_maybe_grant_upload_font_cap( $allcaps, $caps );
+
+		$this->assertArrayHasKey( 'upload_fonts', $result, 'upload_fonts should be granted' );
+		$this->assertTrue( $result['upload_fonts'], 'upload_fonts capability should be true' );
+	}
+}

From ed93188d7ac4b0cc9daaf9aeba06dd9b7fdfc39d Mon Sep 17 00:00:00 2001
From: Anton Vlasenko <vlasenko.anton@gmail.com>
Date: Sat, 24 Feb 2024 13:57:22 +0100
Subject: [PATCH 10/19] Fix the test.

---
 .../font-library/maybeGrantUploadFontCap.php  | 37 +++++--------------
 1 file changed, 10 insertions(+), 27 deletions(-)

diff --git a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
index 52910ebda1aea..003f9c6650498 100644
--- a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
+++ b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
@@ -8,7 +8,7 @@ class Test_Gutenberg_Maybe_Upload_Font_Cap extends WP_UnitTestCase {
 	 * @return string[]
 	 */
 	public function mock_wp_get_font_dir() {
-		return array( 'path' => '/valid/font/directory' );
+		return array( 'path' => get_temp_dir() );
 	}
 
 	/**
@@ -16,25 +16,10 @@ public function mock_wp_get_font_dir() {
 	 *
 	 * @param string $context
 	 *
-	 * @return true|void
+	 * @return bool
 	 */
 	public function mock_wp_is_file_mod_allowed( $context ) {
-		if ( $context === 'can_upload_fonts' ) {
-			return true;
-		}
-	}
-
-	/**
-	 * Mock the wp_is_writable function to return true.
-	 *
-	 * @param string $path
-	 *
-	 * @return true|void
-	 */
-	public function mock_wp_is_writable( $path ) {
-		if ( $path === '/valid/font/directory' ) {
-			return true;
-		}
+		return true;
 	}
 
 	/**
@@ -48,8 +33,8 @@ public function mock_wp_is_writable( $path ) {
 	 * @return string[]
 	 */
 	public function mock_current_user_can( $caps, $cap, $user_id, $args ) {
-		if ( $cap === 'create_posts' && isset( $args[0] ) && $args[0] === 'wp_font_face' ) {
-			return array( 'exist' ); // The 'exist' cap is a minimal capability that all users have
+		if ( $cap === 'edit_theme_options' ) {
+			return array( 'exist' );
 		}
 
 		return $caps;
@@ -57,17 +42,15 @@ public function mock_current_user_can( $caps, $cap, $user_id, $args ) {
 
 	public function set_up() {
 		parent::set_up();
-		add_filter( 'wp_get_font_dir', array( $this, 'mock_wp_get_font_dir' ) );
-		add_filter( 'wp_is_file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
-		add_filter( 'wp_is_writable', array( $this, 'mock_wp_is_writable' ) );
+		add_filter( 'font_dir', array( $this, 'mock_wp_get_font_dir' ) );
+		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
 		add_filter( 'map_meta_cap', array( $this, 'mock_current_user_can' ), 10, 4 );
 	}
 
 	public function tear_down() {
-		remove_filter( 'wp_get_font_dir', array( $this, 'mock_wp_get_font_dir' ) );
-		remove_filter( 'wp_is_file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
-		remove_filter( 'wp_is_writable', array( $this, 'mock_wp_is_writable' ) );
-		remove_filter( 'map_meta_cap', array( $this, 'mock_current_user_can' ), 10 );
+		add_filter( 'font_dir', array( $this, 'mock_wp_get_font_dir' ) );
+		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
+		add_filter( 'map_meta_cap', array( $this, 'mock_current_user_can' ), 10 );
 
 		parent::tear_down();
 	}

From 047662a80859455adf29b0cec80058c40c62d9f1 Mon Sep 17 00:00:00 2001
From: Anton Vlasenko <vlasenko.anton@gmail.com>
Date: Sat, 24 Feb 2024 14:25:24 +0100
Subject: [PATCH 11/19] Fix formatting.

---
 .../font-library/maybeGrantUploadFontCap.php  | 76 +++++++++++++------
 1 file changed, 51 insertions(+), 25 deletions(-)

diff --git a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
index 003f9c6650498..8f3318c2ccfa6 100644
--- a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
+++ b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
@@ -1,6 +1,30 @@
 <?php
 
-class Test_Gutenberg_Maybe_Upload_Font_Cap extends WP_UnitTestCase {
+/**
+ * Test gutenberg_maybe_grant_upload_font_cap().
+ *
+ * @package WordPress
+ * @subpackage Font Library
+ *
+ * @group fonts
+ * @group font-library
+ *
+ * @covers gutenberg_maybe_grant_upload_font_cap
+ */
+class Tests_Fonts_GutenbergMaybeGrantUploadFontCap extends WP_UnitTestCase {
+	public function set_up() {
+		parent::set_up();
+		add_filter( 'font_dir', array( $this, 'mock_wp_get_font_dir' ) );
+		add_filter( 'map_meta_cap', array( $this, 'mock_current_user_can' ), 10, 4 );
+	}
+
+	public function tear_down() {
+		add_filter( 'font_dir', array( $this, 'mock_wp_get_font_dir' ) );
+		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
+		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed_return_false' ) );
+		add_filter( 'map_meta_cap', array( $this, 'mock_current_user_can' ), 10 );
+		parent::tear_down();
+	}
 
 	/**
 	 * Mock the wp_get_font_dir function to return a valid path.
@@ -23,14 +47,25 @@ public function mock_wp_is_file_mod_allowed( $context ) {
 	}
 
 	/**
-	 * Mock current_user_can for 'wp_font_face' post type's 'create_posts' capability to return true.
+	 * Mock the wp_is_file_mod_allowed function to return false.
 	 *
-	 * @param string[] $caps
-	 * @param string $cap
-	 * @param int $user_id
-	 * @param array $args
+	 * @param string $context
 	 *
-	 * @return string[]
+	 * @return bool
+	 */
+	public function mock_wp_is_file_mod_allowed_return_false( $context ) {
+		return false;
+	}
+
+	/**
+	 * Mocks the current_user_can function to conditionally modify capabilities.
+	 *
+	 * @param string[] $caps Current user's capabilities.
+	 * @param string $cap Capability being checked.
+	 * @param int $user_id ID of the user being checked.
+	 * @param array $args Additional arguments for capability check.
+	 *
+	 * @return string[] Modified capabilities array.
 	 */
 	public function mock_current_user_can( $caps, $cap, $user_id, $args ) {
 		if ( $cap === 'edit_theme_options' ) {
@@ -40,29 +75,14 @@ public function mock_current_user_can( $caps, $cap, $user_id, $args ) {
 		return $caps;
 	}
 
-	public function set_up() {
-		parent::set_up();
-		add_filter( 'font_dir', array( $this, 'mock_wp_get_font_dir' ) );
-		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
-		add_filter( 'map_meta_cap', array( $this, 'mock_current_user_can' ), 10, 4 );
-	}
-
-	public function tear_down() {
-		add_filter( 'font_dir', array( $this, 'mock_wp_get_font_dir' ) );
-		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
-		add_filter( 'map_meta_cap', array( $this, 'mock_current_user_can' ), 10 );
-
-		parent::tear_down();
-	}
-
-	public function test_not_granting_upload_fonts_if_not_in_caps() {
+	public function test_should_not_grant_upload_fonts_if_not_in_caps() {
 		$caps   = array( 'edit_posts' ); // 'upload_fonts' is not in $caps
 		$result = gutenberg_maybe_grant_upload_font_cap( array(), $caps );
 		$this->assertArrayNotHasKey( 'upload_fonts', $result, 'upload_fonts should not be granted' );
 	}
 
-	public function test_granting_upload_fonts_under_correct_conditions() {
-		// Mock necessary functions and conditions here
+	public function test_should_grant_upload_fonts_under_correct_conditions() {
+		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
 		$allcaps = array();
 		$caps    = array( 'upload_fonts' );
 
@@ -71,4 +91,10 @@ public function test_granting_upload_fonts_under_correct_conditions() {
 		$this->assertArrayHasKey( 'upload_fonts', $result, 'upload_fonts should be granted' );
 		$this->assertTrue( $result['upload_fonts'], 'upload_fonts capability should be true' );
 	}
+
+	public function test_should_not_grant_upload_fonts_if_conditions_not_met() {
+		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed_return_false' ) );
+		$result = gutenberg_maybe_grant_upload_font_cap( array(), array( 'upload_fonts' ) );
+		$this->assertArrayNotHasKey( 'upload_fonts', $result, 'upload_fonts should not be granted under incorrect conditions' );
+	}
 }

From 7d44a12ffab8bfa83bb47896bdedae5c35b25db2 Mon Sep 17 00:00:00 2001
From: Anton Vlasenko <vlasenko.anton@gmail.com>
Date: Sat, 24 Feb 2024 14:38:13 +0100
Subject: [PATCH 12/19] Fix code style.

---
 .../font-library/maybeGrantUploadFontCap.php  | 34 ++++++++-----------
 1 file changed, 15 insertions(+), 19 deletions(-)

diff --git a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
index 8f3318c2ccfa6..e6346d6bbc3c9 100644
--- a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
+++ b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
@@ -1,5 +1,4 @@
 <?php
-
 /**
  * Test gutenberg_maybe_grant_upload_font_cap().
  *
@@ -39,10 +38,9 @@ public function mock_wp_get_font_dir() {
 	 * Mock the wp_is_file_mod_allowed function to return true.
 	 *
 	 * @param string $context
-	 *
 	 * @return bool
 	 */
-	public function mock_wp_is_file_mod_allowed( $context ) {
+	public function mock_wp_is_file_mod_allowed( $context ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
 		return true;
 	}
 
@@ -50,25 +48,23 @@ public function mock_wp_is_file_mod_allowed( $context ) {
 	 * Mock the wp_is_file_mod_allowed function to return false.
 	 *
 	 * @param string $context
-	 *
 	 * @return bool
 	 */
-	public function mock_wp_is_file_mod_allowed_return_false( $context ) {
+	public function mock_wp_is_file_mod_allowed_return_false( $context ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
 		return false;
 	}
 
 	/**
 	 * Mocks the current_user_can function to conditionally modify capabilities.
 	 *
-	 * @param string[] $caps Current user's capabilities.
-	 * @param string $cap Capability being checked.
-	 * @param int $user_id ID of the user being checked.
-	 * @param array $args Additional arguments for capability check.
-	 *
+	 * @param string[] $caps    Current user's capabilities.
+	 * @param string   $cap     Capability being checked.
+	 * @param int      $user_id ID of the user being checked.
+	 * @param array    $args    Additional arguments for capability check.
 	 * @return string[] Modified capabilities array.
 	 */
-	public function mock_current_user_can( $caps, $cap, $user_id, $args ) {
-		if ( $cap === 'edit_theme_options' ) {
+	public function mock_current_user_can( $caps, $cap, $user_id, $args ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+		if ( 'edit_theme_options' === $cap ) {
 			return array( 'exist' );
 		}
 
@@ -78,23 +74,23 @@ public function mock_current_user_can( $caps, $cap, $user_id, $args ) {
 	public function test_should_not_grant_upload_fonts_if_not_in_caps() {
 		$caps   = array( 'edit_posts' ); // 'upload_fonts' is not in $caps
 		$result = gutenberg_maybe_grant_upload_font_cap( array(), $caps );
-		$this->assertArrayNotHasKey( 'upload_fonts', $result, 'upload_fonts should not be granted' );
+		$this->assertArrayNotHasKey( 'upload_fonts', $result, 'upload_fonts capability should not be granted.' );
 	}
 
 	public function test_should_grant_upload_fonts_under_correct_conditions() {
 		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
-		$allcaps = array();
-		$caps    = array( 'upload_fonts' );
 
-		$result = gutenberg_maybe_grant_upload_font_cap( $allcaps, $caps );
+		$caps   = array( 'upload_fonts' );
+		$result = gutenberg_maybe_grant_upload_font_cap( array(), $caps );
 
-		$this->assertArrayHasKey( 'upload_fonts', $result, 'upload_fonts should be granted' );
-		$this->assertTrue( $result['upload_fonts'], 'upload_fonts capability should be true' );
+		$this->assertArrayHasKey( 'upload_fonts', $result, 'upload_fonts capability should be granted.' );
+		$this->assertTrue( $result['upload_fonts'], 'upload_fonts capability should be true.' );
 	}
 
 	public function test_should_not_grant_upload_fonts_if_conditions_not_met() {
 		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed_return_false' ) );
+
 		$result = gutenberg_maybe_grant_upload_font_cap( array(), array( 'upload_fonts' ) );
-		$this->assertArrayNotHasKey( 'upload_fonts', $result, 'upload_fonts should not be granted under incorrect conditions' );
+		$this->assertArrayNotHasKey( 'upload_fonts', $result, 'upload_fonts capability should not be granted under incorrect conditions.' );
 	}
 }

From 090c7a0788fcf976ab53a059dfd5001c9417e7ff Mon Sep 17 00:00:00 2001
From: Anton Vlasenko <vlasenko.anton@gmail.com>
Date: Sat, 24 Feb 2024 15:03:37 +0100
Subject: [PATCH 13/19] Draft test.

---
 .../font-library/deleteFontPostMetaCaps.php   | 87 +++++++++++++++++++
 1 file changed, 87 insertions(+)
 create mode 100644 phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php

diff --git a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
new file mode 100644
index 0000000000000..844e0fa6dc5d0
--- /dev/null
+++ b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
@@ -0,0 +1,87 @@
+<?php
+/**
+ * Test gutenberg_maybe_grant_upload_font_cap().
+ *
+ * @package WordPress
+ * @subpackage Font Library
+ *
+ * @group fonts
+ * @group font-library
+ *
+ * @covers gutenberg_maybe_grant_upload_font_cap
+ */
+class Tests_Fonts_GutenbergMaybeGrantUploadFontCap extends WP_UnitTestCase {
+	public function set_up() {
+		parent::set_up();
+	}
+
+	public function tear_down() {
+		parent::tear_down();
+	}
+
+	// Test non-font post types should return original capabilities
+	public function testNonFontPostType() {
+		$caps       = array( 'edit_posts' ); // Example of original capabilities
+		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( 999 ) ); // Assuming 999 is a non-font post ID
+
+		$this->assertEquals( $caps, $resultCaps, 'Capabilities should remain unchanged for non-font post types.' );
+	}
+
+	// Test non-existent posts should add 'do_not_allow' capability
+	public function testNonExistentPost() {
+		$caps       = array(); // Original capabilities
+		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( 999 ) ); // Assuming 999 is a non-existent post ID
+
+		$this->assertContains( 'do_not_allow', $resultCaps, 'Capabilities should contain "do_not_allow" for non-existent posts.' );
+	}
+
+	// Test 'wp_font_face' post type without associated files
+	public function testFontFacePostTypeWithoutFiles() {
+		$postId = $this->factory->post->create( array( 'post_type' => 'wp_font_face' ) ); // Create a font face post
+		// No font files are associated in this test case
+
+		$caps       = array(); // Original capabilities
+		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( $postId ) );
+
+		$this->assertEquals( $caps, $resultCaps, 'Capabilities should remain unchanged for "wp_font_face" post type without associated files.' );
+	}
+
+	// Test 'wp_font_face' post type with associated files requires 'upload_fonts' capability
+	public function testFontFacePostTypeWithFiles() {
+		$postId = $this->factory->post->create( array( 'post_type' => 'wp_font_face' ) );
+		add_post_meta( $postId, '_wp_font_face_file', 'path/to/font/file' ); // Simulate associated font file
+
+		$caps       = array(); // Original capabilities
+		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( $postId ) );
+
+		$this->assertContains( 'upload_fonts', $resultCaps, 'Capabilities should include "upload_fonts" for "wp_font_face" post type with associated files.' );
+	}
+
+	// Test 'wp_font_family' post type without associated font faces
+	public function testFontFamilyPostTypeWithoutFontFaces() {
+		$postId = $this->factory->post->create( array( 'post_type' => 'wp_font_family' ) ); // Create a font family post
+		// No font faces are associated in this test case
+
+		$caps       = array(); // Original capabilities
+		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( $postId ) );
+
+		$this->assertEquals( $caps, $resultCaps, 'Capabilities should remain unchanged for "wp_font_family" post type without associated font faces.' );
+	}
+
+	// Test 'wp_font_family' post type with at least one font face having files requires 'upload_fonts' capability
+	public function testFontFamilyPostTypeWithFontFacesHavingFiles() {
+		$familyPostId = $this->factory->post->create( array( 'post_type' => 'wp_font_family' ) );
+		$facePostId   = $this->factory->post->create(
+			array(
+				'post_type'   => 'wp_font_face',
+				'post_parent' => $familyPostId,
+			)
+		);
+		add_post_meta( $facePostId, '_wp_font_face_file', 'path/to/font/file' ); // Simulate associated font file with one of the font faces
+
+		$caps       = array(); // Original capabilities
+		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( $familyPostId ) );
+
+		$this->assertContains( 'upload_fonts', $resultCaps, 'Capabilities should include "upload_fonts" for "wp_font_family" post type with at least one associated font face having files.' );
+	}
+}

From b1fb5db0c112b721a971bbe35f3b38d44b1a55a9 Mon Sep 17 00:00:00 2001
From: Anton Vlasenko <vlasenko.anton@gmail.com>
Date: Sat, 24 Feb 2024 15:42:42 +0100
Subject: [PATCH 14/19] Commit WIP.

---
 .../font-library/deleteFontPostMetaCaps.php   | 24 ++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
index 844e0fa6dc5d0..645392b211565 100644
--- a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
+++ b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * Test gutenberg_maybe_grant_upload_font_cap().
+ * Test gutenberg_delete_font_post_meta_caps().
  *
  * @package WordPress
  * @subpackage Font Library
@@ -8,9 +8,9 @@
  * @group fonts
  * @group font-library
  *
- * @covers gutenberg_maybe_grant_upload_font_cap
+ * @covers gutenberg_delete_font_post_meta_caps
  */
-class Tests_Fonts_GutenbergMaybeGrantUploadFontCap extends WP_UnitTestCase {
+class Tests_Fonts_GutenbergDeleteFontPostMetaCaps extends WP_UnitTestCase {
 	public function set_up() {
 		parent::set_up();
 	}
@@ -19,6 +19,24 @@ public function tear_down() {
 		parent::tear_down();
 	}
 
+	public function test_should_return_original_caps_when_do_not_allow_is_present() {
+		$caps = array( 'don_not_allow' );
+		$result = gutenberg_delete_font_post_meta_caps( $caps, 'some_cap', 1, array( 999 ) );
+		$this->assertSameSetsWithIndex( $caps, $result );
+	}
+
+	public function test_should_return_original_caps_if_not_delete_post_capability() {
+		$caps = array( 'my_capability' );
+		$result = gutenberg_delete_font_post_meta_caps( $caps, 'some_cap', 1, array( 999 ) );
+		$this->assertSameSetsWithIndex( $caps, $result );
+	}
+
+	public function test_should_add_do_not_allow_for_non_existent_post() {
+		$caps = array( 'my_capability' );
+		$result = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( 999 ) );
+		$this->assertContainsEquals( 'do_not_allow', $result );
+	}
+
 	// Test non-font post types should return original capabilities
 	public function testNonFontPostType() {
 		$caps       = array( 'edit_posts' ); // Example of original capabilities

From 1dc3153c8ad22edaa34e8f8f89182fabc3abcb59 Mon Sep 17 00:00:00 2001
From: Anton Vlasenko <vlasenko.anton@gmail.com>
Date: Sat, 24 Feb 2024 16:44:42 +0100
Subject: [PATCH 15/19] Implement additional test cases for
 Tests_Fonts_GutenbergDeleteFontPostMetaCaps.

---
 .../font-library/deleteFontPostMetaCaps.php   | 86 +++++++------------
 1 file changed, 31 insertions(+), 55 deletions(-)

diff --git a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
index 645392b211565..d9c55d66ff788 100644
--- a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
+++ b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
@@ -20,86 +20,62 @@ public function tear_down() {
 	}
 
 	public function test_should_return_original_caps_when_do_not_allow_is_present() {
-		$caps = array( 'don_not_allow' );
+		$caps   = array( 'don_not_allow' );
 		$result = gutenberg_delete_font_post_meta_caps( $caps, 'some_cap', 1, array( 999 ) );
 		$this->assertSameSetsWithIndex( $caps, $result );
 	}
 
 	public function test_should_return_original_caps_if_not_delete_post_capability() {
-		$caps = array( 'my_capability' );
+		$caps   = array( 'my_capability' );
 		$result = gutenberg_delete_font_post_meta_caps( $caps, 'some_cap', 1, array( 999 ) );
 		$this->assertSameSetsWithIndex( $caps, $result );
 	}
 
 	public function test_should_add_do_not_allow_for_non_existent_post() {
-		$caps = array( 'my_capability' );
+		$caps   = array( 'my_capability' );
 		$result = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( 999 ) );
 		$this->assertContainsEquals( 'do_not_allow', $result );
 	}
 
-	// Test non-font post types should return original capabilities
-	public function testNonFontPostType() {
-		$caps       = array( 'edit_posts' ); // Example of original capabilities
-		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( 999 ) ); // Assuming 999 is a non-font post ID
-
-		$this->assertEquals( $caps, $resultCaps, 'Capabilities should remain unchanged for non-font post types.' );
+	public function test_should_return_original_caps_for_wp_font_face_posts_with_no_files() {
+		$post_id = $this->factory->post->create( array( 'post_type' => 'wp_font_face' ) );
+		$result  = gutenberg_delete_font_post_meta_caps( array(), 'delete_post', 1, array( $post_id ) );
+		$this->assertEquals( array(), $result, 'Capabilities should remain unchanged for "wp_font_face" post type without associated files.' );
 	}
 
-	// Test non-existent posts should add 'do_not_allow' capability
-	public function testNonExistentPost() {
-		$caps       = array(); // Original capabilities
-		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( 999 ) ); // Assuming 999 is a non-existent post ID
-
-		$this->assertContains( 'do_not_allow', $resultCaps, 'Capabilities should contain "do_not_allow" for non-existent posts.' );
+	public function test_should_include_upload_fonts_cap_for_font_post_types_with_files() {
+		$post_id = $this->factory->post->create( array( 'post_type' => 'wp_font_face' ) );
+		add_post_meta( $post_id, '_wp_font_face_file', 'path/to/font/file' );
+		$caps   = array();
+		$result = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( $post_id ) );
+		$this->assertContainsEquals( 'upload_fonts', $result, 'Capabilities should include "upload_fonts" for "wp_font_face" post type with associated files.' );
 	}
 
-	// Test 'wp_font_face' post type without associated files
-	public function testFontFacePostTypeWithoutFiles() {
-		$postId = $this->factory->post->create( array( 'post_type' => 'wp_font_face' ) ); // Create a font face post
-		// No font files are associated in this test case
-
-		$caps       = array(); // Original capabilities
-		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( $postId ) );
-
-		$this->assertEquals( $caps, $resultCaps, 'Capabilities should remain unchanged for "wp_font_face" post type without associated files.' );
+	public function test_should_return_original_caps_for_wp_font_family_posts_with_no_files() {
+		$post_id = $this->factory->post->create( array( 'post_type' => 'wp_font_family' ) );
+		$caps    = array();
+		$result  = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( $post_id ) );
+		$this->assertEquals( $caps, $result, 'Capabilities should remain unchanged for "wp_font_family" post type without associated font faces.' );
 	}
 
-	// Test 'wp_font_face' post type with associated files requires 'upload_fonts' capability
-	public function testFontFacePostTypeWithFiles() {
-		$postId = $this->factory->post->create( array( 'post_type' => 'wp_font_face' ) );
-		add_post_meta( $postId, '_wp_font_face_file', 'path/to/font/file' ); // Simulate associated font file
-
-		$caps       = array(); // Original capabilities
-		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( $postId ) );
-
-		$this->assertContains( 'upload_fonts', $resultCaps, 'Capabilities should include "upload_fonts" for "wp_font_face" post type with associated files.' );
-	}
-
-	// Test 'wp_font_family' post type without associated font faces
-	public function testFontFamilyPostTypeWithoutFontFaces() {
-		$postId = $this->factory->post->create( array( 'post_type' => 'wp_font_family' ) ); // Create a font family post
-		// No font faces are associated in this test case
-
-		$caps       = array(); // Original capabilities
-		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( $postId ) );
-
-		$this->assertEquals( $caps, $resultCaps, 'Capabilities should remain unchanged for "wp_font_family" post type without associated font faces.' );
-	}
-
-	// Test 'wp_font_family' post type with at least one font face having files requires 'upload_fonts' capability
-	public function testFontFamilyPostTypeWithFontFacesHavingFiles() {
-		$familyPostId = $this->factory->post->create( array( 'post_type' => 'wp_font_family' ) );
-		$facePostId   = $this->factory->post->create(
+	public function test_should_include_upload_fonts_cap_for_font_faces_types_with_files() {
+		$font_family_post_id = $this->factory->post->create( array( 'post_type' => 'wp_font_family' ) );
+		$font_face_post_id   = $this->factory->post->create(
 			array(
 				'post_type'   => 'wp_font_face',
-				'post_parent' => $familyPostId,
+				'post_parent' => $font_family_post_id,
 			)
 		);
-		add_post_meta( $facePostId, '_wp_font_face_file', 'path/to/font/file' ); // Simulate associated font file with one of the font faces
+		add_post_meta( $font_face_post_id, '_wp_font_face_file', 'path/to/font/file' );
 
-		$caps       = array(); // Original capabilities
-		$resultCaps = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( $familyPostId ) );
+		$result = gutenberg_delete_font_post_meta_caps( array(), 'delete_post', 1, array( $font_family_post_id ) );
+		$this->assertContains( 'upload_fonts', $result, 'Capabilities should include "upload_fonts" for "wp_font_family" post type with at least one associated font face having files.' );
+	}
 
-		$this->assertContains( 'upload_fonts', $resultCaps, 'Capabilities should include "upload_fonts" for "wp_font_family" post type with at least one associated font face having files.' );
+	public function test_should_return_original_caps_for_non_font_post_types() {
+		$caps    = array( 'edit_posts' );
+		$post_id = $this->factory->post->create( array( 'post_type' => 'post' ) );
+		$result  = gutenberg_delete_font_post_meta_caps( $caps, 'delete_post', 1, array( $post_id ) );
+		$this->assertEquals( $caps, $result, 'Capabilities should remain unchanged for non-font post types.' );
 	}
 }

From 8b1663f45191f0e24c536fc97b12fc893ee94cd8 Mon Sep 17 00:00:00 2001
From: Anton Vlasenko <vlasenko.anton@gmail.com>
Date: Sat, 24 Feb 2024 16:49:02 +0100
Subject: [PATCH 16/19] Remove the unused methods.

---
 .../tests/fonts/font-library/deleteFontPostMetaCaps.php   | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
index d9c55d66ff788..674fd8805ba4d 100644
--- a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
+++ b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
@@ -11,14 +11,6 @@
  * @covers gutenberg_delete_font_post_meta_caps
  */
 class Tests_Fonts_GutenbergDeleteFontPostMetaCaps extends WP_UnitTestCase {
-	public function set_up() {
-		parent::set_up();
-	}
-
-	public function tear_down() {
-		parent::tear_down();
-	}
-
 	public function test_should_return_original_caps_when_do_not_allow_is_present() {
 		$caps   = array( 'don_not_allow' );
 		$result = gutenberg_delete_font_post_meta_caps( $caps, 'some_cap', 1, array( 999 ) );

From 9925dddd4ca43331bc4b2edcf0087eb78bd44794 Mon Sep 17 00:00:00 2001
From: Anton Vlasenko <vlasenko.anton@gmail.com>
Date: Tue, 27 Feb 2024 17:52:08 +0100
Subject: [PATCH 17/19] Fix the unit tests.

---
 .../tests/fonts/font-library/deleteFontPostMetaCaps.php   | 8 ++++++--
 .../tests/fonts/font-library/maybeGrantUploadFontCap.php  | 8 ++++----
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
index 674fd8805ba4d..24d86f051e647 100644
--- a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
+++ b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
@@ -14,13 +14,17 @@ class Tests_Fonts_GutenbergDeleteFontPostMetaCaps extends WP_UnitTestCase {
 	public function test_should_return_original_caps_when_do_not_allow_is_present() {
 		$caps   = array( 'don_not_allow' );
 		$result = gutenberg_delete_font_post_meta_caps( $caps, 'some_cap', 1, array( 999 ) );
-		$this->assertSameSetsWithIndex( $caps, $result );
+		ksort( $caps );
+		ksort( $result );
+		$this->assertSame( $caps, $result, 'The original capabilities should not be changed when do_not_allow is present.' );
 	}
 
 	public function test_should_return_original_caps_if_not_delete_post_capability() {
 		$caps   = array( 'my_capability' );
 		$result = gutenberg_delete_font_post_meta_caps( $caps, 'some_cap', 1, array( 999 ) );
-		$this->assertSameSetsWithIndex( $caps, $result );
+		ksort( $caps );
+		ksort( $result );
+		$this->assertSame( $caps, $result, 'The original capabilities should not be changed if no delete_post capability.' );
 	}
 
 	public function test_should_add_do_not_allow_for_non_existent_post() {
diff --git a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
index e6346d6bbc3c9..88c1b92ba2e62 100644
--- a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
+++ b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
@@ -18,10 +18,10 @@ public function set_up() {
 	}
 
 	public function tear_down() {
-		add_filter( 'font_dir', array( $this, 'mock_wp_get_font_dir' ) );
-		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
-		add_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed_return_false' ) );
-		add_filter( 'map_meta_cap', array( $this, 'mock_current_user_can' ), 10 );
+		remove_filter( 'font_dir', array( $this, 'mock_wp_get_font_dir' ) );
+		remove_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed' ) );
+		remove_filter( 'file_mod_allowed', array( $this, 'mock_wp_is_file_mod_allowed_return_false' ) );
+		remove_filter( 'map_meta_cap', array( $this, 'mock_current_user_can' ), 10 );
 		parent::tear_down();
 	}
 

From 1edf1acc87c22c35a170b2a64ca90b7bda618b56 Mon Sep 17 00:00:00 2001
From: Anton Vlasenko <vlasenko.anton@gmail.com>
Date: Tue, 27 Feb 2024 18:04:00 +0100
Subject: [PATCH 18/19] Rename test classes.

---
 phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php  | 2 +-
 phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
index 24d86f051e647..242354e0ebcf3 100644
--- a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
+++ b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
@@ -10,7 +10,7 @@
  *
  * @covers gutenberg_delete_font_post_meta_caps
  */
-class Tests_Fonts_GutenbergDeleteFontPostMetaCaps extends WP_UnitTestCase {
+class Tests_Fonts_DeleteFontPostMetaCaps extends WP_UnitTestCase {
 	public function test_should_return_original_caps_when_do_not_allow_is_present() {
 		$caps   = array( 'don_not_allow' );
 		$result = gutenberg_delete_font_post_meta_caps( $caps, 'some_cap', 1, array( 999 ) );
diff --git a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
index 88c1b92ba2e62..e46699dd2358e 100644
--- a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
+++ b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
@@ -10,7 +10,7 @@
  *
  * @covers gutenberg_maybe_grant_upload_font_cap
  */
-class Tests_Fonts_GutenbergMaybeGrantUploadFontCap extends WP_UnitTestCase {
+class Tests_Fonts_MaybeGrantUploadFontCap extends WP_UnitTestCase {
 	public function set_up() {
 		parent::set_up();
 		add_filter( 'font_dir', array( $this, 'mock_wp_get_font_dir' ) );

From 742d09111e537ff2f8ee795d19bef91a670b1a84 Mon Sep 17 00:00:00 2001
From: Anton Vlasenko <vlasenko.anton@gmail.com>
Date: Tue, 27 Feb 2024 18:41:11 +0100
Subject: [PATCH 19/19] Fix the covers tag.

---
 phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php  | 2 +-
 phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
index 242354e0ebcf3..063e75af79898 100644
--- a/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
+++ b/phpunit/tests/fonts/font-library/deleteFontPostMetaCaps.php
@@ -8,7 +8,7 @@
  * @group fonts
  * @group font-library
  *
- * @covers gutenberg_delete_font_post_meta_caps
+ * @covers ::gutenberg_delete_font_post_meta_caps
  */
 class Tests_Fonts_DeleteFontPostMetaCaps extends WP_UnitTestCase {
 	public function test_should_return_original_caps_when_do_not_allow_is_present() {
diff --git a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
index e46699dd2358e..685ed2d761740 100644
--- a/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
+++ b/phpunit/tests/fonts/font-library/maybeGrantUploadFontCap.php
@@ -8,7 +8,7 @@
  * @group fonts
  * @group font-library
  *
- * @covers gutenberg_maybe_grant_upload_font_cap
+ * @covers ::gutenberg_maybe_grant_upload_font_cap
  */
 class Tests_Fonts_MaybeGrantUploadFontCap extends WP_UnitTestCase {
 	public function set_up() {