From 7c7cb9e6f4159936e46223ca260c9f70a325bde7 Mon Sep 17 00:00:00 2001 From: Rich Tabor Date: Thu, 22 Jun 2023 10:33:33 -0400 Subject: [PATCH 1/3] Add ungroup transform as transform to p --- packages/block-library/src/quote/transforms.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/packages/block-library/src/quote/transforms.js b/packages/block-library/src/quote/transforms.js index d4cd77177bf03..7275ceb5006c7 100644 --- a/packages/block-library/src/quote/transforms.js +++ b/packages/block-library/src/quote/transforms.js @@ -109,6 +109,19 @@ const transforms = { } ); }, }, + { + type: 'block', + blocks: [ 'core/paragraph' ], + transform: ( { citation }, innerBlocks ) => + citation + ? [ + ...innerBlocks, + createBlock( 'core/paragraph', { + content: citation, + } ), + ] + : innerBlocks, + }, { type: 'block', blocks: [ 'core/group' ], From 1f837559e5a5d81bed756d3abdf94da86a59a020 Mon Sep 17 00:00:00 2001 From: Rich Tabor Date: Fri, 23 Jun 2023 10:25:49 -0400 Subject: [PATCH 2/3] Lint --- packages/block-library/src/quote/transforms.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-library/src/quote/transforms.js b/packages/block-library/src/quote/transforms.js index 7275ceb5006c7..4e153a6399029 100644 --- a/packages/block-library/src/quote/transforms.js +++ b/packages/block-library/src/quote/transforms.js @@ -119,7 +119,7 @@ const transforms = { createBlock( 'core/paragraph', { content: citation, } ), - ] + ] : innerBlocks, }, { From acbeeef6989e5ad992c43906562d40747cf7b93a Mon Sep 17 00:00:00 2001 From: Juan Aldasoro Date: Tue, 27 Jun 2023 16:37:07 +0200 Subject: [PATCH 3/3] Update test and snapshot. --- .../quote/test/__snapshots__/transforms.native.js.snap | 10 ++++++++++ .../block-library/src/quote/test/transforms.native.js | 6 +++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/packages/block-library/src/quote/test/__snapshots__/transforms.native.js.snap b/packages/block-library/src/quote/test/__snapshots__/transforms.native.js.snap index 5b5df918f2bee..65d87d5b0d7bd 100644 --- a/packages/block-library/src/quote/test/__snapshots__/transforms.native.js.snap +++ b/packages/block-library/src/quote/test/__snapshots__/transforms.native.js.snap @@ -22,6 +22,16 @@ exports[`Quote block transforms to Group block 1`] = ` " `; +exports[`Quote block transforms to Paragraph block 1`] = ` +" +

"This will make running your own blog a viable alternative again."

+ + + +

Adrian Zumbrunnen

+" +`; + exports[`Quote block transforms to Pullquote block 1`] = ` "

"This will make running your own blog a viable alternative again."

Adrian Zumbrunnen
diff --git a/packages/block-library/src/quote/test/transforms.native.js b/packages/block-library/src/quote/test/transforms.native.js index 46c4eb2b6f972..25030e0a018d4 100644 --- a/packages/block-library/src/quote/test/transforms.native.js +++ b/packages/block-library/src/quote/test/transforms.native.js @@ -21,7 +21,11 @@ const initialHtml = ` `; const transformsWithInnerBlocks = [ 'Columns', 'Group' ]; -const blockTransforms = [ 'Pullquote', ...transformsWithInnerBlocks ]; +const blockTransforms = [ + 'Pullquote', + 'Paragraph', + ...transformsWithInnerBlocks, +]; setupCoreBlocks();