Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in code documentation standards. #4530

Closed
wants to merge 1 commit into from

Conversation

BE-Webdesign
Copy link
Contributor

I might have missed it, but I did not see anything detailing the in code
documentation standards. Here is an addition to the CONTRIBUTING.md,
with a base line description. As we figure out what we want to do regarding components we can revise this.

I might have missed it, but I did not see anything detailing the in code
documentation standards. Here is an addition to the CONTRIBUTING.md,
with a base line standard.
@ntwb
Copy link
Member

ntwb commented Jan 17, 2018

Maybe this should be added to https://github.com/WordPress/gutenberg/blob/master/docs/coding-guidelines.md instead?

@BE-Webdesign
Copy link
Contributor Author

Maybe both. I knew there was another file!

@gziolo
Copy link
Member

gziolo commented Jan 17, 2018

I would also vote for Coding Guidelines and reference it in CONTRIBUTING.md. Otherwise it looks good :)


This project uses [JSDoc](http://usejsdoc.org/) for doc blocks. Inline code should be used for describing individual pieces in detail. The in code documentation will hopefully in the future be repurposed for [the WordPress code reference](https://developer.wordpress.org/reference/). If you would like to help contribute to the in code documentation, try adding a JSDoc header to something that needs one! It would be greatly appreciated!

In code documentation priorities:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you come to this prioritization? Should we set prioritization expectations, or merely that all things are to be documented (prioritization implies that you don't need to document everything)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you come to this prioritization?

I believe I went off of what was already documented, and what seemed undocumented (higher undocumented rate lower on prioritization). We can take that part out.

I wrote this for feedback, I have no idea if there should be prioritization. I would probably be most in favor of documenting everything so we can potentially extract the docs out programmatically, but we did not come to a consensus in the JS meeting. Without your and Riad's buy in, since ya'll are doing the vast bulk of the work, it would be unfair to try to impose anything on you two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants