Update RangeControl to render number optionally #4523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think any slider needs a number so lets keep that for now. Sliders have enough issues without taking numbers away :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here is my suggestion to make RangeControl number input field optional. It may be cases where showing it may lead to confusion to why it's there. Number is shown by default to ensure backwards compatibility.
Feel free to ignore this PR if it makes sense to leave it as non-optional.
How Has This Been Tested?
The code has been linted.
Created a test block using range control. Tested the block by using
showNumber={false}andshowNumber={true}and not specify the property at all.Screenshots (jpeg or gifs if applicable):
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: