Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try new gallery markup #3996

Merged
merged 6 commits into from
Jan 18, 2018
Merged

Try new gallery markup #3996

merged 6 commits into from
Jan 18, 2018
+195 −144

Commits on Jan 18, 2018

  1. Try new gallery markup 

    This is a new version of the PR by #3441 by @samikeijonen. It's just basically "rebased".

It seems to be working fine in practice, the chief purpose is to make the gallery be list based.

I'm getting "modified externally" warnings, though.
    Joen Asmussen committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    d8eaefb View commit details
    Browse the repository at this point in the history

  2. Address feedback 

    - Move li outside of component
- Fix CSS typo
- Add deprecated section
    Joen Asmussen committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    4466445 View commit details
    Browse the repository at this point in the history

  3. Replace all instances of blocks-gallery-image

    Joen Asmussen committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    3da0798 View commit details
    Browse the repository at this point in the history

  4. Try adjusting deprecated attributes 

    Also re-add the deprecated CSS class.
    Joen Asmussen committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    450f716 View commit details
    Browse the repository at this point in the history

  5. Gallery Block: Fix deprecated version

    @youknowriad
    youknowriad committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    91b2504 View commit details
    Browse the repository at this point in the history

  6. Gallery Block: Fix tests

    @youknowriad
    youknowriad committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    d04b78d View commit details
    Browse the repository at this point in the history