From 2d698ffe1e84c26fdc8ac9242160f19c7618d274 Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 14:11:31 +0300 Subject: [PATCH 01/14] Upgrade to latest react-native-modal To fix "Animated.event now requires a second argument for options" caused by using a fairly old version of the lib. --- package-lock.json | 2 +- packages/react-native-editor/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 3c83cf4d2998c3..6d80e6332a1c45 100644 --- a/package-lock.json +++ b/package-lock.json @@ -14589,7 +14589,7 @@ "react-native-hsv-color-picker": "git+https://github.com/wordpress-mobile/react-native-hsv-color-picker.git#dfe4d06595fefc9b4d48ce0ced029076c80dab74", "react-native-keyboard-aware-scroll-view": "git+https://github.com/wordpress-mobile/react-native-keyboard-aware-scroll-view.git#6febe4faf7ff51579087bac105f62be8e4c4015d", "react-native-linear-gradient": "git+https://github.com/wordpress-mobile/react-native-linear-gradient.git#deafc7a7b3dcfdc2a2d8327b5727cb393f1cabf7", - "react-native-modal": "^6.5.0", + "react-native-modal": "^11.10.0", "react-native-prompt-android": "git+https://github.com/wordpress-mobile/react-native-prompt-android.git#6406b77d0162262c868bcbbaa0766bfafbf43742", "react-native-reanimated": "git+https://github.com/wordpress-mobile/react-native-reanimated.git#047ae6064e2bcfdaeb1f25d1d38157359ba96cb6", "react-native-safe-area": "^0.5.0", diff --git a/packages/react-native-editor/package.json b/packages/react-native-editor/package.json index 7e37526eb26f92..610078d40c323f 100644 --- a/packages/react-native-editor/package.json +++ b/packages/react-native-editor/package.json @@ -62,7 +62,7 @@ "react-native-hsv-color-picker": "git+https://github.com/wordpress-mobile/react-native-hsv-color-picker#dfe4d06595fefc9b4d48ce0ced029076c80dab74", "react-native-keyboard-aware-scroll-view": "git+https://github.com/wordpress-mobile/react-native-keyboard-aware-scroll-view.git#6febe4faf7ff51579087bac105f62be8e4c4015d", "react-native-linear-gradient": "git+https://github.com/wordpress-mobile/react-native-linear-gradient.git#deafc7a7b3dcfdc2a2d8327b5727cb393f1cabf7", - "react-native-modal": "^6.5.0", + "react-native-modal": "^11.10.0", "react-native-prompt-android": "git+https://github.com/wordpress-mobile/react-native-prompt-android.git#6406b77d0162262c868bcbbaa0766bfafbf43742", "react-native-reanimated": "git+https://github.com/wordpress-mobile/react-native-reanimated.git#047ae6064e2bcfdaeb1f25d1d38157359ba96cb6", "react-native-safe-area": "^0.5.0", From 1e05044a9989ee13fede82383d40b27136df304c Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 15:32:42 +0300 Subject: [PATCH 02/14] Additional `npm install` managed to bump more instances --- package-lock.json | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/package-lock.json b/package-lock.json index 6d80e6332a1c45..717c5c0230cfe4 100644 --- a/package-lock.json +++ b/package-lock.json @@ -14599,6 +14599,17 @@ "react-native-svg": "git+https://github.com/wordpress-mobile/react-native-svg.git#83c4e7c16b704c7706339341b22434b29f0b27d6", "react-native-url-polyfill": "^1.1.2", "react-native-video": "git+https://github.com/wordpress-mobile/react-native-video.git#e74bb901f37f86a8842232468b43c9cbaedb6aa4" + }, + "dependencies": { + "react-native-modal": { + "version": "11.10.0", + "resolved": "https://registry.npmjs.org/react-native-modal/-/react-native-modal-11.10.0.tgz", + "integrity": "sha512-syRYDJYSh16bR37R5EKU9T/wC+5bEOfF17IUqf5URdhbEDd+hxyMInC++l45E8oI+MtdOaEp9yAws5xDqk8dnA==", + "requires": { + "prop-types": "^15.6.2", + "react-native-animatable": "1.3.3" + } + } } }, "@wordpress/readable-js-assets-webpack-plugin": { @@ -50369,15 +50380,6 @@ "version": "git+https://github.com/wordpress-mobile/react-native-linear-gradient.git#deafc7a7b3dcfdc2a2d8327b5727cb393f1cabf7", "from": "git+https://github.com/wordpress-mobile/react-native-linear-gradient.git#deafc7a7b3dcfdc2a2d8327b5727cb393f1cabf7" }, - "react-native-modal": { - "version": "6.5.0", - "resolved": "https://registry.npmjs.org/react-native-modal/-/react-native-modal-6.5.0.tgz", - "integrity": "sha512-ewchdETAGd32xLGLK93NETEGkRcePtN7ZwjmLSQnNW1Zd0SRUYE8NqftjamPyfKvK0i2DZjX4YAghGZTqaRUbA==", - "requires": { - "prop-types": "^15.6.1", - "react-native-animatable": "^1.2.4" - } - }, "react-native-prompt-android": { "version": "git+https://github.com/wordpress-mobile/react-native-prompt-android.git#6406b77d0162262c868bcbbaa0766bfafbf43742", "from": "git+https://github.com/wordpress-mobile/react-native-prompt-android.git#6406b77d0162262c868bcbbaa0766bfafbf43742" From b7cc295672d366dbf93620768855c0c0833f5153 Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 15:39:23 +0300 Subject: [PATCH 03/14] Revert "Additional `npm install` managed to bump more instances" This reverts commit 1e05044a9989ee13fede82383d40b27136df304c. --- package-lock.json | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/package-lock.json b/package-lock.json index 717c5c0230cfe4..6d80e6332a1c45 100644 --- a/package-lock.json +++ b/package-lock.json @@ -14599,17 +14599,6 @@ "react-native-svg": "git+https://github.com/wordpress-mobile/react-native-svg.git#83c4e7c16b704c7706339341b22434b29f0b27d6", "react-native-url-polyfill": "^1.1.2", "react-native-video": "git+https://github.com/wordpress-mobile/react-native-video.git#e74bb901f37f86a8842232468b43c9cbaedb6aa4" - }, - "dependencies": { - "react-native-modal": { - "version": "11.10.0", - "resolved": "https://registry.npmjs.org/react-native-modal/-/react-native-modal-11.10.0.tgz", - "integrity": "sha512-syRYDJYSh16bR37R5EKU9T/wC+5bEOfF17IUqf5URdhbEDd+hxyMInC++l45E8oI+MtdOaEp9yAws5xDqk8dnA==", - "requires": { - "prop-types": "^15.6.2", - "react-native-animatable": "1.3.3" - } - } } }, "@wordpress/readable-js-assets-webpack-plugin": { @@ -50380,6 +50369,15 @@ "version": "git+https://github.com/wordpress-mobile/react-native-linear-gradient.git#deafc7a7b3dcfdc2a2d8327b5727cb393f1cabf7", "from": "git+https://github.com/wordpress-mobile/react-native-linear-gradient.git#deafc7a7b3dcfdc2a2d8327b5727cb393f1cabf7" }, + "react-native-modal": { + "version": "6.5.0", + "resolved": "https://registry.npmjs.org/react-native-modal/-/react-native-modal-6.5.0.tgz", + "integrity": "sha512-ewchdETAGd32xLGLK93NETEGkRcePtN7ZwjmLSQnNW1Zd0SRUYE8NqftjamPyfKvK0i2DZjX4YAghGZTqaRUbA==", + "requires": { + "prop-types": "^15.6.1", + "react-native-animatable": "^1.2.4" + } + }, "react-native-prompt-android": { "version": "git+https://github.com/wordpress-mobile/react-native-prompt-android.git#6406b77d0162262c868bcbbaa0766bfafbf43742", "from": "git+https://github.com/wordpress-mobile/react-native-prompt-android.git#6406b77d0162262c868bcbbaa0766bfafbf43742" From 822123e555e003f0dcec0a93f8f2fc7ee26a0b72 Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 15:40:28 +0300 Subject: [PATCH 04/14] Manually bump the react-native-modal entry in package-lock.json --- package-lock.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index 6d80e6332a1c45..dffe10eb527e88 100644 --- a/package-lock.json +++ b/package-lock.json @@ -50370,12 +50370,12 @@ "from": "git+https://github.com/wordpress-mobile/react-native-linear-gradient.git#deafc7a7b3dcfdc2a2d8327b5727cb393f1cabf7" }, "react-native-modal": { - "version": "6.5.0", - "resolved": "https://registry.npmjs.org/react-native-modal/-/react-native-modal-6.5.0.tgz", - "integrity": "sha512-ewchdETAGd32xLGLK93NETEGkRcePtN7ZwjmLSQnNW1Zd0SRUYE8NqftjamPyfKvK0i2DZjX4YAghGZTqaRUbA==", + "version": "11.10.0", + "resolved": "https://registry.npmjs.org/react-native-modal/-/react-native-modal-11.10.0.tgz", + "integrity": "sha512-syRYDJYSh16bR37R5EKU9T/wC+5bEOfF17IUqf5URdhbEDd+hxyMInC++l45E8oI+MtdOaEp9yAws5xDqk8dnA==", "requires": { - "prop-types": "^15.6.1", - "react-native-animatable": "^1.2.4" + "prop-types": "^15.6.2", + "react-native-animatable": "1.3.3" } }, "react-native-prompt-android": { From 0ce67edabb530783e130c14a74ca76e79f9025b3 Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 15:53:19 +0300 Subject: [PATCH 05/14] onSwipe is deprecated, use onSwipeComplete As per https://github.com/react-native-modal/react-native-modal/blob/b580105f4b2b4e1163bed1228f241b16ea17dacb/src/modal.tsx#L268-L272 --- packages/components/src/mobile/bottom-sheet/index.native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/src/mobile/bottom-sheet/index.native.js b/packages/components/src/mobile/bottom-sheet/index.native.js index b026bd36c3d907..6848b6863e473b 100644 --- a/packages/components/src/mobile/bottom-sheet/index.native.js +++ b/packages/components/src/mobile/bottom-sheet/index.native.js @@ -495,7 +495,7 @@ class BottomSheet extends Component { backdropOpacity={ 0.2 } onBackdropPress={ this.onCloseBottomSheet } onBackButtonPress={ this.onHardwareButtonPress } - onSwipe={ this.onCloseBottomSheet } + onSwipeComplete={ this.onCloseBottomSheet } onDismiss={ Platform.OS === 'ios' ? this.onDismiss : undefined } onModalHide={ Platform.OS === 'android' ? this.onDismiss : undefined From 711238c2afe52cbf77c92ce72a4abf4ac5f506f2 Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 16:02:25 +0300 Subject: [PATCH 06/14] fetch() is deprecated for isScreenReaderEnabled See https://github.com/facebook/react-native/blob/v0.64.0/Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L94-L99 --- packages/block-editor/src/components/inserter/index.native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-editor/src/components/inserter/index.native.js b/packages/block-editor/src/components/inserter/index.native.js index c09eda5473d62d..ea071ea242f3b4 100644 --- a/packages/block-editor/src/components/inserter/index.native.js +++ b/packages/block-editor/src/components/inserter/index.native.js @@ -171,7 +171,7 @@ export class Inserter extends Component { } onInserterToggledAnnouncement( isOpen ) { - AccessibilityInfo.fetch().done( ( isEnabled ) => { + AccessibilityInfo.isScreenReaderEnabled().done( ( isEnabled ) => { if ( isEnabled ) { const isIOS = Platform.OS === 'ios'; const announcement = isOpen From d6cf2f8f098b61a71c2dfb0718f2f6a032ecf25c Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 16:26:27 +0300 Subject: [PATCH 07/14] Toolbar needs label set As per the doc https://github.com/WordPress/gutenberg/blob/7fc4197a6494c040fc3d4e491f22602e058fb126/packages/components/src/toolbar/index.js#L30-L35 --- .../src/components/floating-toolbar/index.native.js | 5 ++++- .../src/components/ungroup-button/index.native.js | 2 +- .../src/components/header/header-toolbar/index.native.js | 5 ++++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/block-editor/src/components/floating-toolbar/index.native.js b/packages/block-editor/src/components/floating-toolbar/index.native.js index 50fce7857ff59a..b349513b8b4de0 100644 --- a/packages/block-editor/src/components/floating-toolbar/index.native.js +++ b/packages/block-editor/src/components/floating-toolbar/index.native.js @@ -83,7 +83,10 @@ const FloatingToolbar = ( { pointerEvents={ showFloatingToolbar ? 'auto' : 'none' } > { showNavUpButton && ( - + + { showKeyboardHideButton && ( - + Date: Thu, 17 Jun 2021 16:40:47 +0300 Subject: [PATCH 08/14] componentWillUnmount is deprecated, use componentDidMount Which is also the recommended way to add subscriptions. See https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#adding-event-listeners-or-subscriptions --- packages/edit-post/src/components/visual-editor/index.native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/edit-post/src/components/visual-editor/index.native.js b/packages/edit-post/src/components/visual-editor/index.native.js index 82ea41896894d4..886e56e493938b 100644 --- a/packages/edit-post/src/components/visual-editor/index.native.js +++ b/packages/edit-post/src/components/visual-editor/index.native.js @@ -24,7 +24,7 @@ export default class VisualEditor extends Component { }; } - componentWillMount() { + componentDidMount() { this.keyboardDidShow = Keyboard.addListener( 'keyboardDidShow', this.keyboardDidShow From ce1baea24d3f8dc0eb16b90cad584ba33fe3b514 Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 16:43:09 +0300 Subject: [PATCH 09/14] Podfile.lock updated after `npm run core ios` --- packages/react-native-editor/ios/Podfile.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-native-editor/ios/Podfile.lock b/packages/react-native-editor/ios/Podfile.lock index b293ce4cac226e..faf33e21c624fa 100644 --- a/packages/react-native-editor/ios/Podfile.lock +++ b/packages/react-native-editor/ios/Podfile.lock @@ -457,7 +457,7 @@ SPEC CHECKSUMS: BVLinearGradient: b2d297a15cf094d1947df4f0519779bb3a7f2392 DoubleConversion: cf9b38bf0b2d048436d9a82ad2abe1404f11e7de FBLazyVector: 49cbe4b43e445b06bf29199b6ad2057649e4c8f5 - FBReactNativeSpec: 420ad7ff87adc491b45199891c72ea531fa4926e + FBReactNativeSpec: c59a3cde8d0336ac8239c33e89e70a0daa170d2b glog: 73c2498ac6884b13ede40eda8228cb1eee9d9d62 Gutenberg: 829c1db189c6f47728327bb1503026f42698cdb6 RCT-Folly: ec7a233ccc97cc556cf7237f0db1ff65b986f27c @@ -475,9 +475,9 @@ SPEC CHECKSUMS: react-native-get-random-values: 03edb8dcc2d3f43e55aa67ea13b61b6723bbf047 react-native-keyboard-aware-scroll-view: 6cb84879bf07e4cc1caed18b11fb928e142adac6 react-native-safe-area: c9cf765aa2dd96159476a99633e7d462ce5bb94f - react-native-safe-area-context: e471852c5ed67eea4b10c5d9d43c1cebae3b231d + react-native-safe-area-context: f0906bf8bc9835ac9a9d3f97e8bde2a997d8da79 react-native-slider: 2e42dc91e7ab8b35a9c7f2eb3532729a41d0dbe2 - react-native-video: e5dd0649534076cd6d09a0db51c617fa668d534a + react-native-video: b8767f54061e475ddd38c22375f46f4d93e5fdfd React-perflogger: 9c547d8f06b9bf00cb447f2b75e8d7f19b7e02af React-RCTActionSheet: 3080b6e12e0e1a5b313c8c0050699b5c794a1b11 React-RCTAnimation: 3f96f21a497ae7dabf4d2f150ee43f906aaf516f @@ -491,7 +491,7 @@ SPEC CHECKSUMS: React-runtimeexecutor: cad74a1eaa53ee6e7a3620231939d8fe2c6afcf0 ReactCommon: cfe2b7fd20e0dbd2d1185cd7d8f99633fbc5ff05 ReactNativeDarkMode: 6d807bc8373b872472c8541fc3341817d979a6fb - RNCMaskedView: dfeba59697c44d36abec79c062aeb1ea343d610d + RNCMaskedView: 66caacf33c86eaa7d22b43178dd998257d5c2e4d RNGestureHandler: 5e58135436aacc1c5d29b75547d3d2b9430d052c RNReanimated: f05baf4cd76b6eab2e4d7e2b244424960b968918 RNScreens: 953633729a42e23ad0c93574d676b361e3335e8b From 91036c13f32c2e679ad0b423a00a0321d71cdc9f Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 16:46:40 +0300 Subject: [PATCH 10/14] Revert "Toolbar needs label set" This reverts commit d6cf2f8f098b61a71c2dfb0718f2f6a032ecf25c. --- .../src/components/floating-toolbar/index.native.js | 5 +---- .../src/components/ungroup-button/index.native.js | 2 +- .../src/components/header/header-toolbar/index.native.js | 5 +---- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/packages/block-editor/src/components/floating-toolbar/index.native.js b/packages/block-editor/src/components/floating-toolbar/index.native.js index b349513b8b4de0..50fce7857ff59a 100644 --- a/packages/block-editor/src/components/floating-toolbar/index.native.js +++ b/packages/block-editor/src/components/floating-toolbar/index.native.js @@ -83,10 +83,7 @@ const FloatingToolbar = ( { pointerEvents={ showFloatingToolbar ? 'auto' : 'none' } > { showNavUpButton && ( - + + { showKeyboardHideButton && ( - + Date: Thu, 17 Jun 2021 16:52:44 +0300 Subject: [PATCH 11/14] Use ToolbarGroup in native mobile instead of label-less Toolbar Label-less Toolbar is deprecated https://github.com/WordPress/gutenberg/blob/7fc4197a6494c040fc3d4e491f22602e058fb126/packages/components/src/toolbar/index.js#L30-L35 Tried to add labels with d6cf2f8f0 but introduced issues: the keyboard dismiss button was out of place. --- .../src/components/floating-toolbar/index.native.js | 6 +++--- .../src/components/ungroup-button/index.native.js | 6 +++--- .../src/components/header/header-toolbar/index.native.js | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/block-editor/src/components/floating-toolbar/index.native.js b/packages/block-editor/src/components/floating-toolbar/index.native.js index 50fce7857ff59a..f4ebf1d9ebe8da 100644 --- a/packages/block-editor/src/components/floating-toolbar/index.native.js +++ b/packages/block-editor/src/components/floating-toolbar/index.native.js @@ -6,7 +6,7 @@ import { Animated, Easing, View, Platform } from 'react-native'; /** * WordPress dependencies */ -import { ToolbarButton, Toolbar } from '@wordpress/components'; +import { ToolbarButton, ToolbarGroup } from '@wordpress/components'; import { useEffect, useState, useRef } from '@wordpress/element'; import { withSelect, withDispatch } from '@wordpress/data'; import { compose } from '@wordpress/compose'; @@ -83,7 +83,7 @@ const FloatingToolbar = ( { pointerEvents={ showFloatingToolbar ? 'auto' : 'none' } > { showNavUpButton && ( - + } /> - + ) } + - + ); } diff --git a/packages/edit-post/src/components/header/header-toolbar/index.native.js b/packages/edit-post/src/components/header/header-toolbar/index.native.js index 903f8c0a8fee66..4f02824fb8baa2 100644 --- a/packages/edit-post/src/components/header/header-toolbar/index.native.js +++ b/packages/edit-post/src/components/header/header-toolbar/index.native.js @@ -16,7 +16,7 @@ import { BlockToolbar, store as blockEditorStore, } from '@wordpress/block-editor'; -import { Toolbar, ToolbarButton } from '@wordpress/components'; +import { ToolbarGroup, ToolbarButton } from '@wordpress/components'; import { keyboardClose, undo as undoIcon, @@ -94,7 +94,7 @@ function HeaderToolbar( { { showKeyboardHideButton && ( - + - + ) } ); From 764f2e5be3ffd811df61d3e9c510243b85e64156 Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 18:10:33 +0300 Subject: [PATCH 12/14] Revert "Podfile.lock updated after `npm run core ios`" This reverts commit ce1baea24d3f8dc0eb16b90cad584ba33fe3b514. --- packages/react-native-editor/ios/Podfile.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-native-editor/ios/Podfile.lock b/packages/react-native-editor/ios/Podfile.lock index faf33e21c624fa..b293ce4cac226e 100644 --- a/packages/react-native-editor/ios/Podfile.lock +++ b/packages/react-native-editor/ios/Podfile.lock @@ -457,7 +457,7 @@ SPEC CHECKSUMS: BVLinearGradient: b2d297a15cf094d1947df4f0519779bb3a7f2392 DoubleConversion: cf9b38bf0b2d048436d9a82ad2abe1404f11e7de FBLazyVector: 49cbe4b43e445b06bf29199b6ad2057649e4c8f5 - FBReactNativeSpec: c59a3cde8d0336ac8239c33e89e70a0daa170d2b + FBReactNativeSpec: 420ad7ff87adc491b45199891c72ea531fa4926e glog: 73c2498ac6884b13ede40eda8228cb1eee9d9d62 Gutenberg: 829c1db189c6f47728327bb1503026f42698cdb6 RCT-Folly: ec7a233ccc97cc556cf7237f0db1ff65b986f27c @@ -475,9 +475,9 @@ SPEC CHECKSUMS: react-native-get-random-values: 03edb8dcc2d3f43e55aa67ea13b61b6723bbf047 react-native-keyboard-aware-scroll-view: 6cb84879bf07e4cc1caed18b11fb928e142adac6 react-native-safe-area: c9cf765aa2dd96159476a99633e7d462ce5bb94f - react-native-safe-area-context: f0906bf8bc9835ac9a9d3f97e8bde2a997d8da79 + react-native-safe-area-context: e471852c5ed67eea4b10c5d9d43c1cebae3b231d react-native-slider: 2e42dc91e7ab8b35a9c7f2eb3532729a41d0dbe2 - react-native-video: b8767f54061e475ddd38c22375f46f4d93e5fdfd + react-native-video: e5dd0649534076cd6d09a0db51c617fa668d534a React-perflogger: 9c547d8f06b9bf00cb447f2b75e8d7f19b7e02af React-RCTActionSheet: 3080b6e12e0e1a5b313c8c0050699b5c794a1b11 React-RCTAnimation: 3f96f21a497ae7dabf4d2f150ee43f906aaf516f @@ -491,7 +491,7 @@ SPEC CHECKSUMS: React-runtimeexecutor: cad74a1eaa53ee6e7a3620231939d8fe2c6afcf0 ReactCommon: cfe2b7fd20e0dbd2d1185cd7d8f99633fbc5ff05 ReactNativeDarkMode: 6d807bc8373b872472c8541fc3341817d979a6fb - RNCMaskedView: 66caacf33c86eaa7d22b43178dd998257d5c2e4d + RNCMaskedView: dfeba59697c44d36abec79c062aeb1ea343d610d RNGestureHandler: 5e58135436aacc1c5d29b75547d3d2b9430d052c RNReanimated: f05baf4cd76b6eab2e4d7e2b244424960b968918 RNScreens: 953633729a42e23ad0c93574d676b361e3335e8b From 170e4dcefa880f2acaf62a936a862a7926d4c65f Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 18:27:28 +0300 Subject: [PATCH 13/14] Temporary Metro patch until RN upgrades Metro Issue message: "Error: EISDIR: illegal operation on a directory, read" Fix PR on Metro: https://github.com/facebook/metro/pull/567 --- patches/metro+0.64.0.patch | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 patches/metro+0.64.0.patch diff --git a/patches/metro+0.64.0.patch b/patches/metro+0.64.0.patch new file mode 100644 index 00000000000000..249ae5cecd324b --- /dev/null +++ b/patches/metro+0.64.0.patch @@ -0,0 +1,13 @@ +diff --git a/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js b/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js +index 5f32fc5..2b80fda 100644 +--- a/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js ++++ b/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js +@@ -346,7 +346,7 @@ class UnableToResolveError extends Error { + try { + file = fs.readFileSync(this.originModulePath, "utf8"); + } catch (error) { +- if (error.code === "ENOENT") { ++ if (error.code === "ENOENT" || error.code === 'EISDIR') { + // We're probably dealing with a virtualised file system where + // `this.originModulePath` doesn't actually exist on disk. + // We can't show a code frame, but there's no need to let this I/O From 9871a347ff4ac27741288b3981b1f0601bce64d9 Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Thu, 17 Jun 2021 18:55:51 +0300 Subject: [PATCH 14/14] Animated.event needs is second param always set --- .../components/src/focal-point-picker/index.native.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/components/src/focal-point-picker/index.native.js b/packages/components/src/focal-point-picker/index.native.js index ba81919c1a0540..3d9547bdb4eb19 100644 --- a/packages/components/src/focal-point-picker/index.native.js +++ b/packages/components/src/focal-point-picker/index.native.js @@ -92,10 +92,10 @@ function FocalPointPicker( props ) { pan.extractOffset(); // Set offset to current value }, // Move cursor to match delta drag - onPanResponderMove: Animated.event( [ - null, - { dx: pan.x, dy: pan.y }, - ] ), + onPanResponderMove: Animated.event( + [ null, { dx: pan.x, dy: pan.y } ], + { useNativeDriver: false } + ), onPanResponderRelease: ( event ) => { shouldEnableBottomSheetScroll( true ); pan.flattenOffset(); // Flatten offset into value