From 21176a71d22168a994bc60f3b5508f3b7cc911bf Mon Sep 17 00:00:00 2001 From: KHeo Date: Thu, 30 Apr 2020 09:09:59 +0900 Subject: [PATCH 1/3] Use optional catch binding! --- packages/url/src/is-url.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/url/src/is-url.js b/packages/url/src/is-url.js index b84932c8aae2e..1fda847947ed4 100644 --- a/packages/url/src/is-url.js +++ b/packages/url/src/is-url.js @@ -19,7 +19,7 @@ export function isURL( url ) { try { new URL( url ); return true; - } catch ( error ) { + } catch { return false; } } From 171ce96ffb0473cbe9488f151dc363c8b6bc9e8b Mon Sep 17 00:00:00 2001 From: KHeo Date: Thu, 30 Apr 2020 09:12:19 +0900 Subject: [PATCH 2/3] Use optional chaining. --- packages/block-editor/src/components/link-control/index.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/block-editor/src/components/link-control/index.js b/packages/block-editor/src/components/link-control/index.js index 2e7234f7809e3..838cbe81aa850 100644 --- a/packages/block-editor/src/components/link-control/index.js +++ b/packages/block-editor/src/components/link-control/index.js @@ -326,9 +326,9 @@ function LinkControl( { * the next render, if focus was within the wrapper when editing finished. */ function stopEditing() { - isEndingEditWithFocus.current = - !! wrapperNode.current && - wrapperNode.current.contains( document.activeElement ); + isEndingEditWithFocus.current = wrapperNode.current?.contains( + document.activeElement + ); setIsEditingLink( false ); } From 750318bdabe17e28e98d6cbafc11e949d88a458d Mon Sep 17 00:00:00 2001 From: Kukhyeon Heo Date: Fri, 1 May 2020 09:59:43 +0900 Subject: [PATCH 3/3] Update packages/block-editor/src/components/link-control/index.js Co-authored-by: Andrew Duthie --- packages/block-editor/src/components/link-control/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-editor/src/components/link-control/index.js b/packages/block-editor/src/components/link-control/index.js index 838cbe81aa850..e8f003dbe2996 100644 --- a/packages/block-editor/src/components/link-control/index.js +++ b/packages/block-editor/src/components/link-control/index.js @@ -326,7 +326,7 @@ function LinkControl( { * the next render, if focus was within the wrapper when editing finished. */ function stopEditing() { - isEndingEditWithFocus.current = wrapperNode.current?.contains( + isEndingEditWithFocus.current = !! wrapperNode.current?.contains( document.activeElement );