{
@@ -72,6 +73,7 @@ export function DimensionControl( props ) {
value={ value }
onChange={ onChangeSpacingSize }
options={ formatSizesAsOptions( sizes ) }
+ help={ help }
/>
);
}
diff --git a/packages/components/src/dimension-control/style.scss b/packages/components/src/dimension-control/style.scss
index 7f1481747dfe1..302941fb4dc4a 100644
--- a/packages/components/src/dimension-control/style.scss
+++ b/packages/components/src/dimension-control/style.scss
@@ -10,13 +10,20 @@
align-items: center;
margin-right: 1em;
margin-bottom: 0;
+ width: 10em; // ensure labels and fields align right
.dashicon {
margin-right: 0.5em;
+ flex-shrink: 0;
}
}
- &.is-manual .components-base-control__label {
- width: 10em;
+ .components-base-control__help {
+ display: flex;
+ align-items: center;
+ margin-top: -4px;
+ margin-left: auto;
+ margin-bottom: 0;
+ padding-left: 7em;
}
}
diff --git a/packages/components/src/dimension-control/test/__snapshots__/index.test.js.snap b/packages/components/src/dimension-control/test/__snapshots__/index.test.js.snap
index 45b7a137fb9c8..161bd6941fabe 100644
--- a/packages/components/src/dimension-control/test/__snapshots__/index.test.js.snap
+++ b/packages/components/src/dimension-control/test/__snapshots__/index.test.js.snap
@@ -3,6 +3,7 @@
exports[`DimensionControl rendering renders with custom sizes 1`] = `
@@ -36,6 +37,7 @@ exports[`DimensionControl rendering renders with custom sizes 1`] = `
exports[`DimensionControl rendering renders with defaults 1`] = `
@@ -77,6 +79,7 @@ exports[`DimensionControl rendering renders with defaults 1`] = `
exports[`DimensionControl rendering renders with icon and custom icon label 1`] = `
@@ -130,6 +133,7 @@ exports[`DimensionControl rendering renders with icon and custom icon label 1`]
exports[`DimensionControl rendering renders with icon and default icon label 1`] = `
diff --git a/packages/e2e-tests/fixtures/blocks/core__group.json b/packages/e2e-tests/fixtures/blocks/core__group.json
index 71d94f926dccc..f2f1df46cc1a1 100644
--- a/packages/e2e-tests/fixtures/blocks/core__group.json
+++ b/packages/e2e-tests/fixtures/blocks/core__group.json
@@ -5,7 +5,11 @@
"isValid": true,
"attributes": {
"backgroundColor": "secondary",
- "align": "full"
+ "align": "full",
+ "marginSize": "",
+ "marginUnit": "px",
+ "paddingSize": "",
+ "paddingUnit": "px"
},
"innerBlocks": [
{