Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Indication that Panel Body cannot be collapsed #9889

Closed
milesdelliott opened this issue Sep 14, 2018 · 2 comments
Closed

No Indication that Panel Body cannot be collapsed #9889

milesdelliott opened this issue Sep 14, 2018 · 2 comments
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.

Comments

@milesdelliott
Copy link
Contributor

Describe the bug
The Panel Body component accepts an opened prop which if passed will force the panel open. When the panel is forced open there is no indication that the panel cannot be collapsed( visually or in the code)

Expected behavior
I think at a minimum the arrow should be hidden, and maybe a disabled state on the button, or rendering a different element other than button. I'm not sure what other indications should be there

I have a branch ready to remove the arrow icon, but I figured I would open this issue to get feedback on what more should be done.

Screenshots
This Panel cannot be collapsed
screen shot 2018-09-13 at 7 19 46 pm

This panel can be collapsed
screen shot 2018-09-13 at 7 19 54 pm

Additional context
Using Gutenberg version 3.8

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] UI Components Impacts or related to the UI component system labels Sep 17, 2018
@karmatosed
Copy link
Member

I would say the arrow should be hidden if it can't be collapsed, there seems no point in showing the arrow if that is the case.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Oct 8, 2018
@rodrigoi
Copy link

rodrigoi commented Mar 9, 2019

I think I'll close this since it'sa duplicate of #9522 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants