Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add external link button #969

Closed
jasmussen opened this issue Jun 1, 2017 · 7 comments
Closed

UI: Add external link button #969

jasmussen opened this issue Jun 1, 2017 · 7 comments
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. [Type] Question Questions about the design or development of the editor.

Comments

@jasmussen
Copy link
Contributor

Once you've published your post, you want the link to that post. You can get that link through the permalink interface in #577, and you can get it in the notice you get when you publish in #967.

But outside of that, should there be another affordance for getting the link?

Here's a design that we mocked up for this editor, and have since been testing in Calypso:

external link

external link hover

@jasmussen jasmussen added General Interface Parts of the UI which don't fall neatly under other labels. Design [Type] Question Questions about the design or development of the editor. labels Jun 1, 2017
@youknowriad youknowriad self-assigned this Jun 1, 2017
@afercia
Copy link
Contributor

afercia commented Jun 1, 2017

Where in the tab sequence this link will be placed? For keyboard users discoverability is fundamental. Also, as noted in other issues too, one specific SCAG requirement is to group controls in a logical way. Related controls should be grouped. To me, the placement of this link looks far from ideal from a document structure perspective.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jun 1, 2017
@paulwilde
Copy link
Contributor

The admin toolbar already has a 'View Post/Page' link, which is more obvious than a random icon, so I question whether this is even needed?

@paaljoachim
Copy link
Contributor

What about renaming the preview button to just calling it "view" ?

@aduth
Copy link
Member

aduth commented Jun 12, 2017

"Preview" still has a place for published posts, as an autosave is similar in purpose as a draft equivalent for unsaved changes to published posts. You may have seen this notice before in the current editor:

Autosave

So a user may potentially want both "View" and "Preview" links for a published post if that's the workflow they prefer for comparing the saved post and unsaved (more accurately un-published) changes.

@joedolson
Copy link
Contributor

Is there any reason a "View" link couldn't be placed immediately next to the 'Preview' link? That would certainly meet the expectations for proximity of controls, if the link is added at all. I agree that the existing Admin Toolbar link may satisfy this need, and there isn't currently a 'View' link in the editor, so that's not an expectation.

@jasmussen
Copy link
Contributor Author

Is there any reason a "View" link couldn't be placed immediately next to the 'Preview' link?

The primary reason is keeping a UI that stays largely the same from mobile to desktop, and the more we add to the top bar, the harder it is to fit it on mobile. An option is to simply hide the View link on mobile, but I'd larger we explore other options first.

@jasmussen
Copy link
Contributor Author

Closing for now, as we have a publish notice with a link, and because other discussions on this suggest it might not be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants