-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard coded width for center, right, and left aligned images #9302
Comments
I noticed the same issue when you change content width in the editor via CSS. In the editor image block
|
I noticed this on an un-aligned image as well, not just left/right/center. |
Yep. |
This will (should) be fixed in #6177. It adds a |
Updated the image block branch: https://github.com/WordPress/gutenberg/tree/update/image-block, please test :) |
Updated the branch again, please re-test :) How are you trying to resize the image? The only way to set "hard coded" size is to use the sidebar width or height fields, otherwise the size is set on the front-end automatically (some fixes there in the update). When using |
@gutterberg - I feel your pain and agree that this issue should be fixed but the people in charge of the core code and the core contributors are working hard at the moment tackling a large number of issues in a short amount of time. Patience. Something this obvious will get fixed. Also it's open source...you can always fork it and delete that one constant. A fairly small effort to achieve your goal :-) I speak to you as another issue creator waiting patiently and optimistically that Gutenberg will slow down long enough to take a deep breath and solve issues such as this one before shipping. |
You have to remind yourself that these are, in many cases, people like you and I working for free using our spare time to give back to open source. Patience and optimism are a must in open source :-) |
Gutenberg is a big change. Big changes are sometimes messy. WordPress needs to stay relevant in a Wix / Squarespace world. That's the reality. If you do, really, believe that Gutenberg is not the destiny you believe in, perhaps ClassicPress is your better future path. Just a thought...do not mean to be presumptuous or rain on your rant :-) |
You underestimate the Darwinism of the technology market and technology consumers. There is a long list of corpses of dominant technology companies with a stronger market share than WordPress that were pushed aside by competitors: Sperry Univac, Honeywell, Control Data, Digital Equipment Corp., Wang, Data General, Prime, Kodak, Polaroid, Lucent, Nortel, Compaq, Gateway, Lotus, Borland, Novell, Nokia, etc. Though a PR in Gutenberg is probably not the most productive environment for you and I to debate the topic. Let's get back to the issue at hand...."If an image is left, centred, or right aligned, it cannot be resized beyond 580 pixels within the Gutenberg editor regardless of the dimensions of the actual image file." That's at least something we can agree needs fixing :-) |
Describe the bug
If an image is left, centred, or right aligned, it cannot be resized beyond 580 pixels within the Gutenberg editor regardless of the dimensions of the actual image file. This makes it impossible to predict what it will look like on the front end as it will likely display as the actual size specified as opposed to how it shows in the Gutenberg editor.
To Reproduce
Steps to reproduce the behavior:
Add and image
Leave it centered or set it to left or right alined.
Try to display is larger that 580px.
Expected behavior
You should be able to drag-resize the image up to the actual pixel dimensions of the file, whether it's the original, large, medium-large, etc., or at the very least to the content width of the theme.
The culprit is this line of code in /editor/index.js
line 4778: maxWidth: 580,
Desktop (please complete the following information):
Gutenberg version 3.6.2
The text was updated successfully, but these errors were encountered: