Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11: Gallery captions are positioned incorrectly. #8594

Closed
kjellr opened this issue Aug 6, 2018 · 3 comments
Closed

IE11: Gallery captions are positioned incorrectly. #8594

kjellr opened this issue Aug 6, 2018 · 3 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 6, 2018

Describe the bug

On IE11, gallery captions appear below the image, rather than on top of it. They're also hidden by the "Upload an image" drop zone. In the deselected state, the captions are pushed out far to the right of where they're supposed to be.

To Reproduce

  1. Use IE11.
  2. Add a Gallery block.
  3. Attempt to add a caption.

Animated GIF

gallery-captions-ie11

Tested in:
Windows 7, IE 11.0.9600.17420
Gutenberg 3.4

@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks Browser Issues Issues or PRs that are related to browser specific problems labels Aug 6, 2018
@webmandesign
Copy link
Contributor

This could be fixed by applying actual left/right and bottom position for the figcaption absolute positioning styles. So, basically adding this:

figcaption {
	position: absolute;
	left: 0;
	bottom: 0;
	...

I didn't go ahead and created a pull request fixing this as I'm not really sure why there is this flebox set for the gallery figure... So, can anybody explain it? What's the purpose of it? What was the desired layout?

If the flexbox from figure is removed, you can even omit the left: 0; styles above.

@jasmussen
Copy link
Contributor

This PR is fixed by #9762.

Thanks again for the advice here.

@kjellr
Copy link
Contributor Author

kjellr commented Sep 13, 2018

Closed via #9762.

@kjellr kjellr closed this as completed Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants