Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic block: "Paste as Text" notification uses inconsistent styles. #8374

Closed
kjellr opened this issue Aug 1, 2018 · 8 comments
Closed
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Blocks Overall functionality of blocks Needs Dev Ready for, and needs developer efforts [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Milestone

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 1, 2018

Describe the bug

Inside of a classic block, you can toggle a "Paste as Text" button in the toolbar to paste contents as plain text. The first time you select this option, you're shown a notification that explains its functionality:

screen shot 2018-08-01 at 3 18 50 pm

The style and placement of this notification are inconsistent with everything else in the editor — it feels broken. I wonder if we can customize it a bit so it doesn't feel so out of place?

To Reproduce
Steps to reproduce the behavior:

  1. Add a Classic editor block
  2. Click "More" in the classic editor toolbar to show the second row of controls.
  3. Click the "Paste as Text" button in the second row of the classic editor toolbar.

(Note that this issue does exist in the Classic Editor as well.)

@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later Needs Design Needs design efforts. labels Aug 1, 2018
@kjellr kjellr mentioned this issue Aug 1, 2018
6 tasks
@karmatosed
Copy link
Member

Design wise, lets use the strip message we have in place over blocks. I think ideally though yes let's get this made more inline with what we have usually.

@karmatosed karmatosed added the Needs Dev Ready for, and needs developer efforts label Aug 2, 2018
@kjellr
Copy link
Contributor Author

kjellr commented Aug 3, 2018

Thanks! Here's a mockup, using that pattern (Visually, it's similar to the "This block has been modified externally" message).

mockup

@kjellr kjellr removed the Needs Design Needs design efforts. label Aug 3, 2018
@karmatosed
Copy link
Member

@kjellr that totally is what I was thinking thanks.

@ellatrix ellatrix added the [Block] Classic Affects the Classic Editor Block label Oct 31, 2018
@mtias mtias added this to the WordPress 5.0.x Follow Ups milestone Nov 12, 2018
@paaljoachim
Copy link
Contributor

This issue is still valid in WordPress 5.7 beta 3 and Gutenberg plugin 10.
Tested with Twenty Twenty One.

Screen Shot 2021-02-21 at 00 02 23

@tellthemachines @talldan @jasmussen

@talldan
Copy link
Contributor

talldan commented Feb 22, 2021

This is still a very low priority.

@Mamaduka
Copy link
Member

I think we can close this minor bug. The general plan is to deprecate the Classic block. See #50387.

@t-hamano
Copy link
Contributor

If the editor is running as an iframe, the content will be edited in a modal. Note that in this case, the notification text will be almost invisible:

Image

I think we can close this minor bug. The general plan is to deprecate the Classic block. See #50387.

However, I agree with this, so I think this issue can be closed.

@jasmussen
Copy link
Contributor

Let's close for now, and we can reopen if the issue re-emerges.

@jasmussen jasmussen closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Blocks Overall functionality of blocks Needs Dev Ready for, and needs developer efforts [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

10 participants