-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button block - option to 'Open in new window' #8000
Comments
Adding a screenshot showing the current state of the button block floating toolbar:
|
Worth noting this has been mentioned also in #3350 (comment) with some more details. The point is while other blocks (Paragraph, Image, etc.) use a standardised |
@afercia Great point. It may be better to change the |
@chrisvanpatten @aduth @youknowriad (sorry, not sure who's more appropriate to be involved on this issue) Maybe we don't need to use |
Submitted #10128 which addresses this enhancement. |
Will this feature be implemented at the core? if so, when? |
There's another PR #12738 addressing this issue, would be great to see one of them merged soon. |
@shoxton it looks like work on this has been picked up by @nfmohit-wpmudev at #10128 and that there is also recent discussion on that pull request, however, there is no guarantee of a timeline for something like that to get added and generally it depends on how much time the core team and other committers and contributors have to work on pull requests as well as code reviews for each other. In this case, it looks like there's some recent movement which is great! @mvpspl619 thank you so much for the note about 12738! |
Would be amazing, buttons are an important part of a UI, and not being able to direct to an external link in a new tab (as well as nofollow, noopener etc...) is quite a limiting parameter. |
It is essential to have (open in new tab) option just like other components for Buttons as well. +1 vote to have that option in next release. Thanks |
+1 from a WordPress.com customer |
Being able to choose to open a button link in a new window? Yes + 1 on that. |
+1 to this as well. The buttons are great, just that it'll be much better if we could have an option to open it in a new tab. Btw, am quite inexperienced with this so hope you guys don't mind me asking again if it was already asked above or in other threads. May I know what is the quick fix/alternative to make the block open in a new tab? Editing the html? Many thanks! |
Another frustrated Gutenberg user that battles with buttons that do not offer a target setting.... |
@mattpan32 you can try adding the |
Isnt Gutenberg supposed to "streamline the editing". |
|
+1 from a WordPress.com user in #12136336-hc (noting for myself as they asked me to notify them if this ever does end up being implemented) |
+1 |
Also requesting this feature. Thanks |
+1 from a WordPress.com customer |
+1 This feature would be nice. |
This makes the block completely useless. Please add. |
In order to use this button block on landing pages, we need to have |
@lakellie hey there! Thanks for adding this note. I would recommend in the case of someone wanting to follow progress to create a GitHub account and click the "Subscribe" option under Notifications in the column on the right side of this issue.
@kristarella @gpmw for cases where you are doing customer support for a company and someone requests a change, it would be really awesome to include a quote with any reasons why or what the customer's end goals are and how the enhancement would be helpful for them. For me, it makes the request much more compelling and it also helps a lot when working on prioritization.
@dionysous can you please add a comment to #13542 about the |
+1 from a WordPress.com user. |
Hi, has this been resolved? Display of a button of page and upon click, it'll open a new tab or window? |
+1 |
I'd like to point out that this should also be accounted for on the Button component itself (the rel attribute I mean), and by extension components that use Buttons, such as Notices (from what I can tell if I want to do this currently, I have to write it as a button with an onClick callback, when I want a regular link). |
+1 |
Hey there, @wouthe ! Thank you for your query ❤️ This feature is now live in the Gutenberg plugin and will be included in the core soon. In order to be able to use this right now and to also see other cool stuff that we developers are working on, please install the Gutenberg plugin. Thanks! ❤️ Regards, |
Nahid, super, great to hear! If I install the plugin, will it not conflict with the core itself? |
Hi there, @wouthe ! First of all, sincere apologies about the delayed response here. The notification somehow missed my eyes. If you install the plugin, it will not conflict with the core. It is more like an "extension", which lets you experience the upcoming features of the project. Hope this helps. Thanks! Regards, |
Hi @nfmohit-wpmudev do we know when this would become part of the core gutenberg? |
This is already in WordPress 5.3 core, which was released on November 12. |
@GlennMartin1 thanks, so i can disable the plugin and it won't affect/break the button I have already setup |
Yes you can, if you are running WordPress 5.3. Keeping the Gutenberg plugin enabled gives you frequent small editor improvements (about every two weeks when a new Gutenberg version is released). Having the Gutenberg plugin disabled, you'll eventually get the same updates (about every 3-4 months when a new WordPress version is released). |
@GlennMartin1 thanks for the detail info :) |
Now we have the link rel field in the button block, but still not for all other links. |
Please can we have the option to 'open in a new window' on the button block? Either in the inspector controls or done in the same way as links (image below).
This was mentioned in #1404 with the button label but it seems the part about setting the target was missed.
The text was updated successfully, but these errors were encountered: