Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce browser build #7600

Closed
ntwb opened this issue Jun 28, 2018 · 2 comments
Closed

Reintroduce browser build #7600

ntwb opened this issue Jun 28, 2018 · 2 comments
Labels
npm Packages Related to npm packages

Comments

@ntwb
Copy link
Member

ntwb commented Jun 28, 2018

@aduth commented on Wed Aug 02 2017

Related: #23
Slack discussion: https://wordpress.slack.com/archives/C5UNMSU4R/p1501594355646576

The browser build was removed in #23 because the generated file was problematic and could not be used in a browser. Specifically, it still included require CommonJS statements and implicit dependencies on the Babel runtime.

An independent browser bundle may still be useful to include in the packages distributable for developers who would like to use a module independent of WordPress, and without an npm build process. You can see other libraries which support this installation process via tools like unpkg: https://github.com/reactjs/redux#installation

While it's questionable whether this should be a priority, or whether the browser build should occur in a consuming project with npm build process (like Wordpress), it may not be significant effort to reintroduce to existing build variant configurations.

@ntwb ntwb added the npm Packages Related to npm packages label Jun 28, 2018
@youknowriad
Copy link
Contributor

Was looking at the issue and I think this one should be closed. The packages are already used in several projects and there doesn't seem to be use-cases or demand for this.

@gziolo
Copy link
Member

gziolo commented Apr 23, 2019

Based on the fact that there are no comments left on the issue, I also would vote to close this issue. We can always reopen if people think it's still would be useful.

There is also Stop using Node.js built-ins in browser-packaged code which should be addressed instead to ensure that all packages can be executed in the browser and properly exposed through globals when using webpack to build code.

@gziolo gziolo closed this as completed Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Packages Related to npm packages
Projects
None yet
Development

No branches or pull requests

3 participants