Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL: alignment buttons don't work as expected #7415

Closed
azaozz opened this issue Jun 20, 2018 · 2 comments
Closed

RTL: alignment buttons don't work as expected #7415

azaozz opened this issue Jun 20, 2018 · 2 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@azaozz
Copy link
Contributor

azaozz commented Jun 20, 2018

In RTL mode the alignment buttons should work in the same way they work in LTR mode. Currently when clicking Align Left, the content (tested with images) is aligned right. Seems to happen because the CSS that floats the block is run through rtlcss which changes float: left; to float: right;.

In addition there are other "oddities" with the buttons themselves and the tooltips. We should (probably) swap the places of Align Right and Align Left buttons, but the actual buttons should do as they say.
@azaozz azaozz added the [Type] Bug An existing feature does not function as intended label Jun 20, 2018
@yoavf
Copy link
Contributor

yoavf commented Jun 21, 2018

This should be taken care of by #3911

@azaozz
Copy link
Contributor Author

azaozz commented Jun 21, 2018

Right. Not sure why I couldn't find 3911 when searching... Closing as duplicate.

@azaozz azaozz closed this as completed Jun 21, 2018
@petrescugit petrescugit mentioned this issue Dec 25, 2023
Open
@npneeraj npneeraj mentioned this issue Dec 25, 2023
Open
@yaseenaljamal yaseenaljamal mentioned this issue Dec 25, 2023
Open
@naiba4 naiba4 mentioned this issue Dec 25, 2023
Open
@yassine4999 yassine4999 mentioned this issue Dec 25, 2023
Open
@captainbarber99 captainbarber99 mentioned this issue Dec 25, 2023
Open
@soloinovator soloinovator mentioned this issue Dec 25, 2023
Open
@MaxMood96 MaxMood96 mentioned this issue Dec 26, 2023
Open
This was referenced Dec 26, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azaozz @yoavf